Skip to content

branch-3.1: [feat](cloud) change the type to optional in the alter storage vault command #54394#54476

Merged
morrySnow merged 1 commit intobranch-3.1from
auto-pick-54394-branch-3.1
Aug 8, 2025
Merged

branch-3.1: [feat](cloud) change the type to optional in the alter storage vault command #54394#54476
morrySnow merged 1 commit intobranch-3.1from
auto-pick-54394-branch-3.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2025

Cherry-picked from #54394

@felixwluo
[feat](cloud) change the type to optional in the alter storage vault …
567f398 
…command (#54394)

### What problem does this PR solve?

change the type to optional in the alter storage vault command
before
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "type"="S3",
  "s3.access_key" = "new_ak"
);
```
now
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "s3.access_key" = "new_ak"
);
```
@github-actions github-actions bot requested a review from morrySnow as a code owner August 8, 2025 01:59
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 8, 2025
@dataroaring dataroaring reopened this Aug 8, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

TPC-H: Total hot run time: 32601 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 567f398f956d16daeb40858231d0237685915a0c, data reload: false

------ Round 1 ----------------------------------
q1	17579	5583	5453	5453
q2	2057	277	172	172
q3	10427	1235	743	743
q4	10228	853	439	439
q5	8192	2373	2138	2138
q6	182	162	133	133
q7	873	750	620	620
q8	9323	1433	1158	1158
q9	5245	4891	4952	4891
q10	6763	2294	1836	1836
q11	483	286	264	264
q12	332	351	203	203
q13	17795	3581	2989	2989
q14	224	231	222	222
q15	527	469	474	469
q16	434	419	384	384
q17	581	847	355	355
q18	6854	6414	6436	6414
q19	1202	954	526	526
q20	320	347	210	210
q21	3194	2181	2001	2001
q22	1041	1052	981	981
Total cold run time: 103856 ms
Total hot run time: 32601 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5480	5491	5465	5465
q2	235	335	227	227
q3	2211	2618	2390	2390
q4	1337	1788	1329	1329
q5	4573	4871	5029	4871
q6	166	158	130	130
q7	2062	1936	1878	1878
q8	2681	2872	2699	2699
q9	7379	7166	7256	7166
q10	2994	3313	2820	2820
q11	570	511	510	510
q12	630	712	622	622
q13	3457	3825	3184	3184
q14	283	296	269	269
q15	525	475	465	465
q16	451	485	441	441
q17	1212	1727	1251	1251
q18	7474	7418	7357	7357
q19	797	1156	1081	1081
q20	2021	1997	1907	1907
q21	5217	4965	4710	4710
q22	1068	1065	991	991
Total cold run time: 52823 ms
Total hot run time: 51763 ms

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

TPC-DS: Total hot run time: 197237 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 567f398f956d16daeb40858231d0237685915a0c, data reload: false

query1	1286	962	934	934
query2	6278	1938	1952	1938
query3	10968	4366	4770	4366
query4	33088	23937	23468	23468
query5	3717	605	459	459
query6	271	187	188	187
query7	3994	498	322	322
query8	300	239	240	239
query9	9456	2570	2560	2560
query10	477	330	256	256
query11	18077	15384	15240	15240
query12	162	113	107	107
query13	1566	541	411	411
query14	9803	6726	6771	6726
query15	238	204	187	187
query16	8049	653	491	491
query17	1608	766	596	596
query18	2141	443	327	327
query19	204	199	169	169
query20	129	120	114	114
query21	205	124	109	109
query22	4700	4517	4508	4508
query23	35375	34031	34469	34031
query24	7485	2731	2744	2731
query25	508	490	416	416
query26	798	281	172	172
query27	2173	471	368	368
query28	5286	2201	2125	2125
query29	682	597	451	451
query30	241	200	173	173
query31	985	920	847	847
query32	87	58	54	54
query33	533	360	327	327
query34	791	844	557	557
query35	792	814	734	734
query36	1001	1046	980	980
query37	105	96	68	68
query38	4030	4050	4018	4018
query39	1536	1487	1513	1487
query40	217	124	106	106
query41	51	49	50	49
query42	118	110	107	107
query43	520	546	493	493
query44	1343	824	818	818
query45	187	186	173	173
query46	909	1065	707	707
query47	1942	2000	1912	1912
query48	413	425	346	346
query49	727	511	414	414
query50	670	714	445	445
query51	7512	7401	7331	7331
query52	105	102	94	94
query53	238	271	199	199
query54	560	583	477	477
query55	80	81	85	81
query56	284	293	257	257
query57	1293	1252	1190	1190
query58	246	231	212	212
query59	3122	3214	3099	3099
query60	311	282	273	273
query61	113	113	115	113
query62	818	764	702	702
query63	254	207	205	205
query64	3766	1100	779	779
query65	3393	3314	3285	3285
query66	732	418	346	346
query67	16469	15849	15526	15526
query68	4320	858	553	553
query69	509	315	281	281
query70	1179	1143	1137	1137
query71	396	293	263	263
query72	5952	3712	3765	3712
query73	642	745	360	360
query74	10432	9167	9004	9004
query75	3207	3117	2696	2696
query76	3086	1192	769	769
query77	457	391	301	301
query78	10413	10519	9602	9602
query79	3995	858	583	583
query80	809	542	465	465
query81	522	258	224	224
query82	1175	131	89	89
query83	163	160	145	145
query84	245	93	84	84
query85	779	394	307	307
query86	404	325	281	281
query87	4328	4335	4241	4241
query88	5254	2401	2400	2400
query89	432	337	303	303
query90	1787	192	194	192
query91	136	146	112	112
query92	69	57	55	55
query93	2984	891	543	543
query94	734	420	303	303
query95	348	280	276	276
query96	494	612	285	285
query97	3174	3302	3168	3168
query98	236	208	197	197
query99	1564	1397	1314	1314
Total cold run time: 295743 ms
Total hot run time: 197237 ms

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

ClickBench: Total hot run time: 29.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 567f398f956d16daeb40858231d0237685915a0c, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.07
query4	1.62	0.11	0.10
query5	0.54	0.50	0.52
query6	1.12	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.61	0.52	0.50
query10	0.55	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	0.78	0.80	0.79
query15	0.84	0.83	0.85
query16	0.38	0.39	0.37
query17	1.03	1.04	1.05
query18	0.24	0.21	0.22
query19	2.00	1.82	1.87
query20	0.02	0.01	0.01
query21	15.39	0.95	0.58
query22	0.75	0.74	0.63
query23	15.19	1.44	0.53
query24	3.23	1.59	1.53
query25	0.23	0.16	0.16
query26	0.20	0.14	0.14
query27	0.06	0.05	0.04
query28	14.25	0.97	0.44
query29	12.58	3.95	3.30
query30	0.25	0.09	0.07
query31	2.82	0.59	0.38
query32	3.23	0.54	0.46
query33	2.97	3.04	3.03
query34	16.63	5.17	4.51
query35	4.57	4.62	4.57
query36	0.65	0.50	0.50
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 104.53 s
Total hot run time: 29.59 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 8, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/23) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 8, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/23) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 98b279e into branch-3.1 Aug 8, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-54394-branch-3.1 branch August 8, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @felixwluo

Comments