[fix](sc) retry on network error#54419

dataroaring · 2025-08-07T03:12:39Z

1. sc retry is not only needed for cloud mode, so rename the config.
2. retry for socket closed error

Thearas · 2025-08-07T03:12:44Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

dataroaring · 2025-08-07T03:13:38Z

run buildall

fe/fe-common/src/main/java/org/apache/doris/common/Config.java

dataroaring · 2025-08-07T03:22:33Z

run buildall

fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java

dataroaring · 2025-08-07T03:43:26Z

run buildall

1. sc retry is not only needed for cloud mode, so rename the config. 2. retry for socket closed error

dataroaring · 2025-08-07T13:23:00Z

run buildall

github-actions · 2025-08-07T13:28:46Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-07T13:28:48Z

PR approved by anyone and no changes requested.

doris-robot · 2025-08-07T14:09:33Z

TPC-H: Total hot run time: 33857 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d3158868ffaec770dabc4c45f72ba5b6b739237d, data reload: false

------ Round 1 ----------------------------------
q1	17586	5290	5263	5263
q2	1936	301	187	187
q3	10279	1307	706	706
q4	10236	991	533	533
q5	7577	2314	2352	2314
q6	180	168	132	132
q7	893	756	647	647
q8	9322	1336	1109	1109
q9	6836	5151	5293	5151
q10	6897	2363	1984	1984
q11	455	277	257	257
q12	355	370	213	213
q13	17777	3518	2944	2944
q14	226	230	213	213
q15	523	465	464	464
q16	435	409	388	388
q17	562	833	358	358
q18	7369	7032	6960	6960
q19	1702	993	555	555
q20	325	305	220	220
q21	3417	3073	2278	2278
q22	1059	1065	981	981
Total cold run time: 105947 ms
Total hot run time: 33857 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5378	5326	5268	5268
q2	240	316	224	224
q3	2053	2562	2248	2248
q4	1322	1731	1318	1318
q5	4185	4366	4374	4366
q6	213	176	135	135
q7	2027	2067	1775	1775
q8	2579	2515	2463	2463
q9	7006	7351	7262	7262
q10	3206	3340	2924	2924
q11	550	574	499	499
q12	723	770	610	610
q13	3419	3828	3185	3185
q14	335	314	316	314
q15	487	437	452	437
q16	442	496	457	457
q17	1218	1477	1346	1346
q18	11352	7775	7769	7769
q19	3094	1060	1093	1060
q20	1916	1981	1794	1794
q21	10345	4330	4287	4287
q22	1056	1065	1007	1007
Total cold run time: 63146 ms
Total hot run time: 50748 ms

doris-robot · 2025-08-07T14:21:27Z

TPC-DS: Total hot run time: 170400 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d3158868ffaec770dabc4c45f72ba5b6b739237d, data reload: false

============================================
query1	996	376	427	376
query2	6546	1796	1691	1691
query3	6748	235	219	219
query4	27157	23653	22962	22962
query5	4332	652	519	519
query6	335	240	214	214
query7	4637	524	290	290
query8	291	238	225	225
query9	8560	2940	2940	2940
query10	506	344	290	290
query11	16073	14951	14768	14768
query12	182	135	133	133
query13	1680	561	418	418
query14	8813	5921	5897	5897
query15	285	191	168	168
query16	7978	620	469	469
query17	1636	782	626	626
query18	2088	435	313	313
query19	337	208	186	186
query20	149	149	138	138
query21	216	130	119	119
query22	3948	3971	3895	3895
query23	34429	34532	34547	34532
query24	8045	2342	2402	2342
query25	545	524	434	434
query26	795	293	162	162
query27	2568	510	349	349
query28	4178	2312	2302	2302
query29	674	598	487	487
query30	302	235	203	203
query31	891	796	754	754
query32	93	79	77	77
query33	565	436	369	369
query34	813	856	516	516
query35	814	840	765	765
query36	1034	1046	936	936
query37	139	111	90	90
query38	3970	3968	3960	3960
query39	1451	1392	1416	1392
query40	232	149	132	132
query41	61	60	54	54
query42	139	127	129	127
query43	504	520	489	489
query44	1427	875	866	866
query45	190	192	184	184
query46	953	1059	663	663
query47	1791	1856	1792	1792
query48	396	456	319	319
query49	675	506	429	429
query50	657	703	420	420
query51	4235	4303	4190	4190
query52	129	136	124	124
query53	253	292	219	219
query54	667	655	569	569
query55	93	86	89	86
query56	351	361	355	355
query57	1205	1221	1129	1129
query58	332	336	334	334
query59	2595	2611	2522	2522
query60	411	401	379	379
query61	122	122	136	122
query62	817	714	648	648
query63	255	210	209	209
query64	3463	1122	804	804
query65	4211	4186	4132	4132
query66	911	479	335	335
query67	query68	18237	957	953	953
query69	1043	301	301	301
query70	1397	1109	1126	1109
query71	706	342	320	320
query72	9374	2294	2352	2294
query73	3649	660	354	354
query74	9049	8908	8737	8737
query75	7608	3112	2703	2703
query76	8893	1209	783	783
query77	1172	420	342	342
query78	9766	12508	9209	9209
query79	14604	617	592	592
query80	2389	585	482	482
query81	577	260	234	234
query82	493	155	124	124
query83	448	286	262	262
query84	304	94	82	82
query85	965	369	337	337
query86	385	309	284	284
query87	4161	4141	4062	4062
query88	5490	2230	2245	2230
query89	482	357	317	317
query90	2634	238	234	234
query91	147	143	112	112
query92	91	72	70	70
query93	6414	960	668	668
query94	1089	390	287	287
query95	421	341	335	335
query96	511	607	281	281
query97	2660	2701	2606	2606
query98	261	247	231	231
query99	1436	1419	1307	1307
Total cold run time: 308730 ms
Total hot run time: 170400 ms

hello-stephen · 2025-08-07T14:24:12Z

FE UT Coverage Report

Increment line coverage 33.33% (4/12) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2025-08-07T14:26:56Z

ClickBench: Total hot run time: 33.1 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d3158868ffaec770dabc4c45f72ba5b6b739237d, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.05	0.04
query3	0.24	0.07	0.07
query4	1.63	0.11	0.11
query5	0.44	0.41	0.44
query6	1.18	0.67	0.66
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.55	0.47	0.47
query10	0.52	0.53	0.53
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.71	0.64	0.63
query14	0.90	1.16	1.14
query15	0.88	0.90	0.88
query16	0.38	0.38	0.40
query17	1.05	1.06	1.04
query18	0.21	0.20	0.20
query19	1.96	1.79	1.93
query20	0.02	0.02	0.01
query21	15.37	0.83	0.55
query22	0.78	1.04	0.70
query23	15.07	1.12	0.63
query24	6.47	1.63	0.59
query25	0.49	0.24	0.20
query26	0.62	0.15	0.13
query27	0.06	0.05	0.05
query28	10.16	0.89	0.45
query29	12.59	3.81	3.29
query30	3.06	2.99	3.01
query31	2.82	0.57	0.39
query32	3.23	0.58	0.49
query33	3.02	3.22	3.22
query34	16.07	5.36	4.93
query35	4.86	4.96	5.01
query36	0.70	0.52	0.50
query37	0.10	0.08	0.08
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.04	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.06 s
Total hot run time: 33.1 s

Hastyshell

LGTM

1. sc retry is not only needed for cloud mode, so rename the config. 2. retry for socket closed error --------- Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>

Cherry-picked from #54419 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com> Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>

…g name change (#54738) #54419 change the FE config `enable_schema_change_retry_in_cloud_mode` to `enable_schema_change_retry`

Hastyshell reviewed Aug 7, 2025

View reviewed changes

fe/fe-common/src/main/java/org/apache/doris/common/Config.java Outdated Show resolved Hide resolved

Hastyshell reviewed Aug 7, 2025

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java Outdated Show resolved Hide resolved

dataroaring added dev/3.0.x dev/3.1.x p0_easy labels Aug 7, 2025

dataroaring force-pushed the sc_retry_net branch 2 times, most recently from fe33e2e to fa126eb Compare August 7, 2025 13:22

Yongqiang YANG added 4 commits August 7, 2025 21:22

[fix](sc) retry on network error

1cdc476

1. sc retry is not only needed for cloud mode, so rename the config. 2. retry for socket closed error

fix review

498c115

fix

2cebce0

fix

d315886

dataroaring force-pushed the sc_retry_net branch from fa126eb to d315886 Compare August 7, 2025 13:22

luwei16 approved these changes Aug 7, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2025

github-actions bot added the reviewed label Aug 7, 2025

Hastyshell approved these changes Aug 8, 2025

View reviewed changes

dataroaring merged commit 9a26e9b into master Aug 8, 2025
28 of 31 checks passed

github-actions bot mentioned this pull request Aug 8, 2025

branch-3.0: [fix](sc) retry on network error #54419 #54488

Merged

github-actions bot mentioned this pull request Aug 8, 2025

branch-3.1: [fix](sc) retry on network error #54419 #54490

Merged

morrySnow pushed a commit that referenced this pull request Aug 9, 2025

branch-3.1: [fix](sc) retry on network error #54419 (#54490)

3038d52

Cherry-picked from #54419 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com> Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Aug 9, 2025

dataroaring added a commit that referenced this pull request Aug 12, 2025

branch-3.0: [fix](sc) retry on network error #54419 (#54488)

6f34e43

Cherry-picked from #54419 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com> Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>

dataroaring added dev/3.0.8-merged and removed dev/3.0.x labels Aug 12, 2025

bobhan1 mentioned this pull request Aug 14, 2025

[Fix](case) Fix case test_cloud_mow_correctness_inject due to config name change #54738

Merged

16 tasks

gavinchou pushed a commit that referenced this pull request Aug 14, 2025

[Fix](case) Fix case test_cloud_mow_correctness_inject due to confi…

ff95d8c

…g name change (#54738) #54419 change the FE config `enable_schema_change_retry_in_cloud_mode` to `enable_schema_change_retry`

github-actions bot pushed a commit that referenced this pull request Aug 14, 2025

[Fix](case) Fix case test_cloud_mow_correctness_inject due to confi…

d8f1478

…g name change (#54738) #54419 change the FE config `enable_schema_change_retry_in_cloud_mode` to `enable_schema_change_retry`

github-actions bot pushed a commit that referenced this pull request Aug 14, 2025

[Fix](case) Fix case test_cloud_mow_correctness_inject due to confi…

cb174dc

…g name change (#54738) #54419 change the FE config `enable_schema_change_retry_in_cloud_mode` to `enable_schema_change_retry`

gavinchou mentioned this pull request Sep 1, 2025

Release Note 3.0.8 #55553

Open

Conversation

dataroaring commented Aug 7, 2025

Uh oh!

Thearas commented Aug 7, 2025

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

dataroaring commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

hello-stephen commented Aug 7, 2025

FE UT Coverage Report

Uh oh!

doris-robot commented Aug 7, 2025

Uh oh!

Hastyshell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants