Skip to content

branch-3.0: [fix](sc) retry on network error #54419#54488

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-54419-branch-3.0
Aug 12, 2025
Merged

branch-3.0: [fix](sc) retry on network error #54419#54488
dataroaring merged 1 commit intobranch-3.0from
auto-pick-54419-branch-3.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2025

Cherry-picked from #54419

1. sc retry is not only needed for cloud mode, so rename the config.
    2. retry for socket closed error

---------

Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>
@github-actions github-actions bot requested a review from dataroaring as a code owner August 8, 2025 06:41
@Thearas
Copy link
Contributor

Thearas commented Aug 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 8, 2025
@dataroaring dataroaring reopened this Aug 8, 2025
@Thearas
Copy link
Contributor

Thearas commented Aug 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39564 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4d7dcd173d181adf19ce5b0a46d0ea53a96fe815, data reload: false

------ Round 1 ----------------------------------
q1	17595	6785	6571	6571
q2	2063	220	203	203
q3	10455	1125	1158	1125
q4	10218	741	685	685
q5	7725	2808	2845	2808
q6	213	131	130	130
q7	973	629	606	606
q8	9368	1961	1974	1961
q9	6677	6371	6423	6371
q10	6995	2256	2319	2256
q11	456	263	257	257
q12	400	217	218	217
q13	17770	2991	2938	2938
q14	237	214	204	204
q15	518	457	469	457
q16	458	380	372	372
q17	963	590	544	544
q18	7149	6547	6669	6547
q19	1388	1046	1107	1046
q20	482	202	200	200
q21	4179	3154	3088	3088
q22	1112	1002	978	978
Total cold run time: 107394 ms
Total hot run time: 39564 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6623	6539	6631	6539
q2	325	231	225	225
q3	2921	2872	2858	2858
q4	2050	1773	1804	1773
q5	5723	5709	5725	5709
q6	211	130	132	130
q7	2220	1830	1808	1808
q8	3379	3535	3514	3514
q9	8796	8947	8894	8894
q10	3570	3525	3495	3495
q11	594	497	491	491
q12	796	610	623	610
q13	4080	3177	3089	3089
q14	300	268	267	267
q15	514	475	481	475
q16	483	439	430	430
q17	1852	1608	1606	1606
q18	8109	7843	7699	7699
q19	1743	1523	1412	1412
q20	2064	1813	1832	1813
q21	5247	4973	5056	4973
q22	1141	1074	1077	1074
Total cold run time: 62741 ms
Total hot run time: 58884 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6f34e43 into branch-3.0 Aug 12, 2025
24 of 26 checks passed
@github-actions github-actions bot deleted the auto-pick-54419-branch-3.0 branch August 12, 2025 02:50
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants