[Bug](function) fix wrong result about array_agg_foreach#55075

BiteTheDDDDt · 2025-08-20T11:22:02Z

What problem does this PR solve?

related with #50181

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-08-20T11:22:06Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

BiteTheDDDDt · 2025-08-20T11:22:18Z

run buildall

hello-stephen · 2025-08-20T12:20:46Z

BE UT Coverage Report

Increment line coverage 94.74% (18/19) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.58% (16780/28164)
Line Coverage	48.51% (152640/314687)
Region Coverage	37.47% (116040/309648)
Branch Coverage	40.39% (51236/126859)

hello-stephen · 2025-08-20T13:32:09Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (19/19) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.00% (22628/27596)
Line Coverage	74.72% (235014/314524)
Region Coverage	61.87% (194969/315116)
Branch Coverage	66.08% (84459/127822)

BiteTheDDDDt · 2025-08-20T13:42:23Z

run buildall

hello-stephen · 2025-08-20T14:49:41Z

FE UT Coverage Report

Increment line coverage 0.00% (0/18) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2025-08-20T16:19:25Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (19/19) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.96% (22618/27596)
Line Coverage	74.67% (234847/314524)
Region Coverage	61.90% (195046/315116)
Branch Coverage	66.01% (84380/127822)

BiteTheDDDDt · 2025-08-21T03:03:45Z

run buildall

HappenLee · 2025-08-21T04:18:48Z

be/src/vec/aggregate_functions/aggregate_function_array_agg.h

-        null_map->resize(size);
-        nested_column->reserve(size);
+        null_map->resize(begin + size);
+        nested_column->reserve(begin + size);


why here reserve not resize like null map?

BiteTheDDDDt · 2025-08-21T04:59:04Z

run buildall

hello-stephen · 2025-08-21T05:57:15Z

BE UT Coverage Report

Increment line coverage 90.00% (9/10) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.58% (16779/28164)
Line Coverage	48.50% (152622/314680)
Region Coverage	37.49% (116085/309645)
Branch Coverage	40.39% (51233/126853)

HappenLee · 2025-08-21T06:13:25Z

be/src/vec/aggregate_functions/aggregate_function_array_agg.h

        const auto size = rhs.null_map->size();
-        null_map->resize(size);
-        nested_column->reserve(size);
+        null_map->resize(begin + size);


insert_range_from()

BiteTheDDDDt · 2025-08-21T06:19:55Z

run buildall

hello-stephen · 2025-08-21T07:29:27Z

BE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	59.58% (16781/28165)
Line Coverage	48.50% (152605/314663)
Region Coverage	37.47% (116028/309641)
Branch Coverage	40.38% (51217/126849)

hello-stephen · 2025-08-21T08:23:58Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	81.94% (22613/27597)
Line Coverage	74.62% (234687/314504)
Region Coverage	61.89% (195042/315136)
Branch Coverage	66.06% (84430/127816)

hello-stephen · 2025-08-21T10:38:41Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.12% (22663/27597)
Line Coverage	74.82% (235305/314504)
Region Coverage	62.08% (195634/315136)
Branch Coverage	66.26% (84696/127816)

HappenLee

LGTM

github-actions · 2025-08-22T03:56:36Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-08-22T03:56:38Z

PR approved by anyone and no changes requested.

) pick from #55075

…55075 (#55420) pick #55075

) pick from #55075

fix wrong result about array_agg_foreach

2b7eaee

wm1581066 added usercase Important user case type label dev/2.1.x dev/3.0.x dev/3.1.x labels Aug 20, 2025

update

d52082b

ixzc mentioned this pull request Aug 20, 2025

[Bug] array_agg_foreach funtion is broken #52252

Closed

3 tasks

reset

75674fb

HappenLee reviewed Aug 21, 2025

View reviewed changes

fix

68240c3

HappenLee reviewed Aug 21, 2025

View reviewed changes

fix

7369e07

Mryange approved these changes Aug 22, 2025

View reviewed changes

HappenLee approved these changes Aug 22, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 22, 2025

github-actions bot added the reviewed label Aug 22, 2025

BiteTheDDDDt merged commit 7f0785d into apache:master Aug 22, 2025
27 of 28 checks passed

github-actions bot added dev/3.0.x-conflict dev/2.1.x-conflict dev/3.1.x-conflict labels Aug 22, 2025

This was referenced Aug 28, 2025

[Bug](function) fix wrong result about array_agg_foreach #55075 #55412

Merged

[Bug](function) fix wrong result about array_agg_foreach #55075 #55419

Merged

branch-3.1: [Bug](function) fix wrong result about array_agg_foreach #55075 #55420

Merged

yiguolei pushed a commit that referenced this pull request Aug 30, 2025

[Bug](function) fix wrong result about array_agg_foreach #55075 (#55412

c75f42a

) pick from #55075

yiguolei added dev/2.1.12-merged and removed dev/2.1.x dev/2.1.x-conflict labels Aug 30, 2025

morrySnow pushed a commit that referenced this pull request Sep 4, 2025

branch-3.1: [Bug](function) fix wrong result about array_agg_foreach #…

2e5126b

…55075 (#55420) pick #55075

morrySnow added dev/3.1.1-merged and removed dev/3.1.x dev/3.1.x-conflict labels Sep 4, 2025

dataroaring pushed a commit that referenced this pull request Sep 5, 2025

[Bug](function) fix wrong result about array_agg_foreach #55075 (#55419

3c00017

) pick from #55075

dataroaring added dev/3.0.9-merged and removed dev/3.0.x dev/3.0.x-conflict labels Sep 5, 2025

morrySnow mentioned this pull request Sep 22, 2025

Release Note 3.1.1 #56289

Closed

Comments

Conversation

BiteTheDDDDt commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Aug 20, 2025

Uh oh!

BiteTheDDDDt commented Aug 20, 2025

Uh oh!

hello-stephen commented Aug 20, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 20, 2025

BE Regression && UT Coverage Report

Uh oh!

BiteTheDDDDt commented Aug 20, 2025

Uh oh!

hello-stephen commented Aug 20, 2025

FE UT Coverage Report

Uh oh!

hello-stephen commented Aug 20, 2025

BE Regression && UT Coverage Report

Uh oh!

BiteTheDDDDt commented Aug 21, 2025

Uh oh!

HappenLee Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

BiteTheDDDDt commented Aug 21, 2025

Uh oh!

hello-stephen commented Aug 21, 2025

BE UT Coverage Report

Uh oh!

HappenLee Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

BiteTheDDDDt commented Aug 21, 2025

Uh oh!

hello-stephen commented Aug 21, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 21, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 21, 2025

BE Regression && UT Coverage Report

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

BiteTheDDDDt commented Aug 20, 2025 •

edited

Loading