Skip to content

Comments

[Chore](function) add ut for array_agg/collect_list/collect_set#50181

Merged
BiteTheDDDDt merged 14 commits intoapache:masterfrom
BiteTheDDDDt:dev_0419
Apr 24, 2025
Merged

[Chore](function) add ut for array_agg/collect_list/collect_set#50181
BiteTheDDDDt merged 14 commits intoapache:masterfrom
BiteTheDDDDt:dev_0419

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Apr 18, 2025 •
edited
Loading

What problem does this PR solve?

  1. add some ut
  2. split array_agg out from collect
  3. fix some agg function test bug
  4. add and fix some p0 case about foreach
  5. collect's insert_result_into must be input ColumnArray<ColumnNullable>, remove unused code and fix wrong be ut

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 18, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 18, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 18, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.16% (14425/27133)
Line Coverage 42.01% (124946/297400)
Region Coverage 40.84% (63845/156341)
Branch Coverage 35.46% (32096/90512)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 20, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 54.68% (14573/26649)
Line Coverage 44.18% (131186/296966)
Region Coverage 41.36% (75589/182776)
Branch Coverage 35.48% (36567/103078)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 21, 2025

run buildall

@BiteTheDDDDt BiteTheDDDDt changed the title test [Chore](function) add ut for array_agg/collect_list/collect_set Apr 21, 2025
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 21, 2025

run buildall

HappenLee
HappenLee reviewed Apr 21, 2025
View reviewed changes
be/test/vec/aggregate_functions/agg_collect.cpp Outdated
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
Copy link
Contributor

@HappenLee HappenLee Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename should be:agg_collect_test.cpp

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 21, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 22, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 22, 2025

BE UT Coverage Report

Increment line coverage 15.23% (60/394) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.55% (14541/27156)
Line Coverage 42.40% (126035/297287)
Region Coverage 41.22% (64469/156387)
Branch Coverage 35.78% (32388/90528)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 22, 2025

BE UT Coverage Report

Increment line coverage 60.91% (240/394) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.63% (14565/27156)
Line Coverage 42.45% (126194/297304)
Region Coverage 41.27% (64549/156399)
Branch Coverage 35.81% (32425/90540)

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 22, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 60.91% (240/394) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 23, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 23, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 23, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 23, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 23, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 85.00% (323/380) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

HappenLee
HappenLee reviewed Apr 24, 2025
View reviewed changes
be/src/vec/aggregate_functions/aggregate_function_collect.cpp
}

void register_aggregate_function_collect_list(AggregateFunctionSimpleFactory& factory) {
// notice: array_agg only differs from collect_list in that array_agg will show null elements in array
Copy link
Contributor

@HappenLee HappenLee Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment

HappenLee
HappenLee approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 182cde5 into apache:master Apr 24, 2025
27 of 30 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt
[Chore](function) add ut for array_agg/collect_list/collect_set (apac…
55d0fa1 
…he#50181)

### What problem does this PR solve?
1. add some ut
2. split array_agg out from collect
3. fix some agg function test bug
4. add and fix some p0 case about foreach
5. collect's insert_result_into must be input
`ColumnArray<ColumnNullable>`, remove unused code and fix wrong be ut
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Aug 20, 2025
Merged
16 tasks
BiteTheDDDDt added a commit that referenced this pull request Aug 22, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result about array_agg_foreach (#55075)
7f0785d 
related with #50181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @hello-stephen @HappenLee @Mryange