[fix](nereids) fix simplify compare predicate cause by loss precision or cast null#55884

yujun777 · 2025-09-10T12:48:31Z

What problem does this PR solve?

simplify compare predicate have bug:

cast(integer as double) cmp double may cause error due to int to double may losss precision;
for cast(c_bigint as double) compare double literal, will simplify it to c_bigint compare integer like literal,

but notice that, only value between [-2^53 + 1, 2^53 - 1] can integer <=> double conversion be one to one,

for example, for sql cast(c_bigint as double) = cast('1000000000000000000.0' as double), we can't simplify it to c_bigint = 1000000000000000000 because the actual range for c_bigint is [999999999999999936, 1000000000000000064].

mysql> select cast(999999999999999936 as double);
+------------------------------------+
| cast(999999999999999936 as double) |
+------------------------------------+
|                              1e+18 |
+------------------------------------+
1 row in set (0.01 sec)

mysql> select cast(1000000000000000064 as double);
+-------------------------------------+
| cast(1000000000000000064 as double) |
+-------------------------------------+
|                               1e+18 |
+-------------------------------------+
1 row in set (0.00 sec)

so we need check the right literal's bound

cast(integer/decimal as decimal) cmp decimal literal may cause error due to cast may generate null. for cast(slot as decimalX), if the casted slot is integer or decimal, and its range > decimal X's range or its range == decimal X's range and its scale > decimal X's scale, then the cast maybe null, so don't simplify this predicate.

for example: cast(1234 as decimal(6, 3)) will evaluate to null, cast(9.99 as decimal(2, 1)) will be null

mysql> select cast(1234 as decimal(6,  3));
+------------------------------+
| cast(1234 as decimal(6,  3)) |
+------------------------------+
|                         NULL |
+------------------------------+
1 row in set (0.01 sec)

mysql> select cast(9.99  as decimal(2, 1));
+------------------------------+
| cast(9.99  as decimal(2, 1)) |
+------------------------------+
|                         NULL |
+------------------------------+
1 row in set (0.01 sec)

so for sql cast(col as decimal(4, 1)) < 999.8, if col is int or decimal(5, 0) like type we can't simplify it to col < 1000 because the cast result may be null (example col = -10000)

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-09-10T12:48:36Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yujun777 · 2025-09-10T12:48:42Z

run buildall

doris-robot · 2025-09-10T13:12:32Z

TPC-H: Total hot run time: 34682 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34bd2c2be764ffde03f06bd245bfcf6c843a64e6, data reload: false

------ Round 1 ----------------------------------
q1	17603	5215	5052	5052
q2	2004	340	245	245
q3	10214	1385	733	733
q4	10243	1060	525	525
q5	7547	2422	2330	2330
q6	191	185	143	143
q7	940	768	626	626
q8	9352	1295	1194	1194
q9	6858	5108	5060	5060
q10	6893	2414	2013	2013
q11	495	318	274	274
q12	348	367	230	230
q13	17781	3656	3067	3067
q14	251	236	214	214
q15	554	486	498	486
q16	1002	1014	947	947
q17	571	863	363	363
q18	7498	7249	7110	7110
q19	1228	956	540	540
q20	336	358	228	228
q21	3703	2588	2355	2355
q22	1089	1051	947	947
Total cold run time: 106701 ms
Total hot run time: 34682 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5123	5081	5077	5077
q2	247	336	231	231
q3	2193	2729	2323	2323
q4	1333	1789	1317	1317
q5	4264	4533	4662	4533
q6	228	181	136	136
q7	2024	2050	1806	1806
q8	2645	2522	2589	2522
q9	7712	7207	7308	7207
q10	3091	3364	2904	2904
q11	584	536	508	508
q12	752	848	703	703
q13	3532	3950	3594	3594
q14	297	307	298	298
q15	527	487	485	485
q16	1094	1089	1067	1067
q17	1213	1659	1423	1423
q18	7787	7778	7757	7757
q19	845	849	846	846
q20	2082	2158	2020	2020
q21	4977	4536	4408	4408
q22	1073	1062	998	998
Total cold run time: 53623 ms
Total hot run time: 52163 ms

doris-robot · 2025-09-10T13:24:14Z

TPC-DS: Total hot run time: 188874 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34bd2c2be764ffde03f06bd245bfcf6c843a64e6, data reload: false

query1	1027	450	437	437
query2	6577	1722	1728	1722
query3	6760	233	232	232
query4	26628	23563	23139	23139
query5	4620	657	522	522
query6	351	269	242	242
query7	4682	526	308	308
query8	315	261	258	258
query9	8660	2953	2958	2953
query10	509	361	324	324
query11	15877	15041	14784	14784
query12	176	122	117	117
query13	1674	546	430	430
query14	12642	9217	9236	9217
query15	241	190	186	186
query16	7715	652	466	466
query17	1615	768	623	623
query18	2053	430	339	339
query19	228	197	182	182
query20	131	127	127	127
query21	214	130	119	119
query22	4095	4092	4289	4092
query23	34303	32949	32967	32949
query24	7798	2395	2394	2394
query25	577	554	444	444
query26	1232	281	175	175
query27	2702	515	365	365
query28	4348	2291	2269	2269
query29	799	632	500	500
query30	297	228	195	195
query31	920	820	734	734
query32	93	88	83	83
query33	580	405	357	357
query34	791	839	516	516
query35	851	868	781	781
query36	987	1057	942	942
query37	137	122	101	101
query38	3490	3528	3470	3470
query39	1496	1467	1435	1435
query40	230	142	130	130
query41	66	67	61	61
query42	135	122	120	120
query43	501	505	466	466
query44	1351	922	876	876
query45	185	180	175	175
query46	856	1017	655	655
query47	1859	1818	1746	1746
query48	393	426	312	312
query49	763	507	419	419
query50	660	699	409	409
query51	3879	3867	3967	3867
query52	119	120	114	114
query53	248	269	204	204
query54	628	625	546	546
query55	106	98	95	95
query56	347	344	330	330
query57	1205	1232	1115	1115
query58	299	289	302	289
query59	2540	2683	2543	2543
query60	363	364	405	364
query61	169	155	180	155
query62	816	741	651	651
query63	230	194	193	193
query64	4433	1132	830	830
query65	4081	3988	3959	3959
query66	1092	482	358	358
query67	15436	15446	15018	15018
query68	8102	919	581	581
query69	494	350	299	299
query70	1389	1330	1260	1260
query71	539	365	336	336
query72	5784	4963	5144	4963
query73	690	659	364	364
query74	9262	9153	8642	8642
query75	3283	3247	2799	2799
query76	3215	1148	727	727
query77	506	412	340	340
query78	9573	9951	8832	8832
query79	1133	855	604	604
query80	734	587	584	584
query81	491	264	233	233
query82	242	166	140	140
query83	276	271	255	255
query84	263	117	98	98
query85	840	456	431	431
query86	339	320	312	312
query87	3815	3714	3612	3612
query88	2798	2234	2221	2221
query89	381	333	293	293
query90	1735	234	230	230
query91	170	167	135	135
query92	98	79	72	72
query93	1058	979	659	659
query94	639	427	305	305
query95	422	340	330	330
query96	480	592	284	284
query97	2918	2957	2893	2893
query98	250	228	224	224
query99	1318	1410	1287	1287
Total cold run time: 274418 ms
Total hot run time: 188874 ms

doris-robot · 2025-09-10T13:29:43Z

ClickBench: Total hot run time: 30.23 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34bd2c2be764ffde03f06bd245bfcf6c843a64e6, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.11	0.12
query5	0.28	0.27	0.25
query6	1.18	0.66	0.64
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.61	0.53	0.52
query10	0.58	0.58	0.58
query11	0.17	0.12	0.11
query12	0.16	0.13	0.12
query13	0.63	0.66	0.62
query14	1.01	1.03	1.03
query15	0.87	0.84	0.85
query16	0.41	0.40	0.40
query17	1.02	1.05	1.06
query18	0.22	0.20	0.20
query19	1.96	1.83	1.81
query20	0.02	0.01	0.02
query21	15.41	0.98	0.60
query22	0.76	1.18	0.80
query23	14.85	1.38	0.61
query24	6.62	1.04	1.47
query25	0.56	0.15	0.15
query26	0.51	0.16	0.14
query27	0.06	0.06	0.05
query28	9.73	0.99	0.44
query29	12.60	3.96	3.22
query30	0.28	0.15	0.11
query31	2.83	0.60	0.38
query32	3.24	0.56	0.48
query33	3.04	3.27	3.08
query34	15.85	5.49	4.81
query35	4.92	4.89	4.89
query36	0.70	0.51	0.50
query37	0.11	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.02
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 103.74 s
Total hot run time: 30.23 s

hello-stephen · 2025-09-10T13:53:09Z

FE UT Coverage Report

Increment line coverage 93.75% (15/16) 🎉
Increment coverage report
Complete coverage report

morrySnow · 2025-09-10T14:26:50Z

...st/java/org/apache/doris/nereids/rules/expression/rules/SimplifyComparisonPredicateTest.java

add float test case

have add float test

hello-stephen · 2025-09-10T15:17:25Z

FE Regression Coverage Report

Increment line coverage 75.00% (12/16) 🎉
Increment coverage report
Complete coverage report

yujun777 · 2025-09-11T02:42:10Z

run buildall

yujun777 · 2025-09-11T03:02:22Z

run buildall

doris-robot · 2025-09-11T03:21:43Z

TPC-H: Total hot run time: 35001 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95eb5830363f9ccd9f0fe7d465b1408ee17a1e3e, data reload: false

------ Round 1 ----------------------------------
q1	17630	5227	5054	5054
q2	1983	323	238	238
q3	10216	1327	731	731
q4	10239	1025	539	539
q5	7522	2406	2410	2406
q6	184	168	140	140
q7	918	771	636	636
q8	9360	1367	1185	1185
q9	7089	5103	5075	5075
q10	6918	2402	1974	1974
q11	508	321	274	274
q12	359	373	233	233
q13	17788	3891	3124	3124
q14	245	250	221	221
q15	569	495	480	480
q16	1009	1021	946	946
q17	601	857	365	365
q18	7556	7187	7152	7152
q19	1235	967	586	586
q20	357	347	243	243
q21	3832	3179	2386	2386
q22	1085	1032	1013	1013
Total cold run time: 107203 ms
Total hot run time: 35001 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5125	5089	5109	5089
q2	254	339	232	232
q3	2239	2703	2351	2351
q4	1355	1834	1363	1363
q5	4252	4668	4618	4618
q6	225	179	139	139
q7	2027	1970	1835	1835
q8	2629	2633	2674	2633
q9	7441	7363	7274	7274
q10	3108	3381	2844	2844
q11	629	547	519	519
q12	704	814	656	656
q13	3620	4175	3293	3293
q14	290	301	269	269
q15	554	484	473	473
q16	1168	1134	1073	1073
q17	1232	1594	1412	1412
q18	7846	7799	7645	7645
q19	833	820	852	820
q20	2014	2063	1939	1939
q21	5110	4402	4323	4323
q22	1079	1053	1015	1015
Total cold run time: 53734 ms
Total hot run time: 51815 ms

doris-robot · 2025-09-11T03:33:24Z

TPC-DS: Total hot run time: 189497 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95eb5830363f9ccd9f0fe7d465b1408ee17a1e3e, data reload: false

query1	1063	489	413	413
query2	6558	1697	1701	1697
query3	6752	220	232	220
query4	26132	23793	22989	22989
query5	4336	636	524	524
query6	344	230	237	230
query7	4655	545	313	313
query8	329	266	251	251
query9	8671	2936	2908	2908
query10	504	344	303	303
query11	15714	15001	14912	14912
query12	175	131	119	119
query13	1667	558	429	429
query14	10253	9171	9297	9171
query15	214	192	175	175
query16	7426	666	486	486
query17	1235	756	700	700
query18	1997	433	339	339
query19	203	203	169	169
query20	132	127	128	127
query21	209	137	118	118
query22	4169	4314	3933	3933
query23	34040	33132	32947	32947
query24	8181	2392	2439	2392
query25	592	519	454	454
query26	1241	279	170	170
query27	2738	514	374	374
query28	4443	2289	2251	2251
query29	850	625	515	515
query30	293	229	201	201
query31	904	795	759	759
query32	94	85	82	82
query33	607	394	349	349
query34	797	858	530	530
query35	810	830	774	774
query36	980	1028	936	936
query37	132	115	90	90
query38	3584	3523	3552	3523
query39	1517	1419	1422	1419
query40	227	141	126	126
query41	63	70	61	61
query42	130	117	120	117
query43	499	527	455	455
query44	1384	871	854	854
query45	188	178	176	176
query46	852	1008	646	646
query47	1798	1800	1747	1747
query48	403	434	311	311
query49	769	514	416	416
query50	664	675	402	402
query51	3940	3896	4042	3896
query52	115	119	109	109
query53	245	272	199	199
query54	629	609	542	542
query55	100	92	88	88
query56	350	340	324	324
query57	1201	1186	1141	1141
query58	295	276	285	276
query59	2618	2821	2637	2637
query60	381	368	368	368
query61	215	197	204	197
query62	833	784	653	653
query63	239	214	217	214
query64	4646	1161	848	848
query65	4068	4017	3968	3968
query66	1170	454	338	338
query67	15570	15259	15076	15076
query68	7930	919	580	580
query69	518	351	291	291
query70	1346	1302	1290	1290
query71	540	356	330	330
query72	5910	5248	5169	5169
query73	706	659	366	366
query74	8899	9148	8921	8921
query75	3306	3239	2824	2824
query76	3311	1156	734	734
query77	551	402	337	337
query78	9622	9776	8913	8913
query79	1891	823	608	608
query80	699	566	545	545
query81	528	262	234	234
query82	218	167	148	148
query83	270	263	270	263
query84	259	107	88	88
query85	862	467	423	423
query86	381	316	297	297
query87	3679	3809	3627	3627
query88	2788	2283	2278	2278
query89	400	327	310	310
query90	1989	223	225	223
query91	163	171	133	133
query92	89	79	70	70
query93	1293	994	644	644
query94	705	430	335	335
query95	415	332	332	332
query96	484	594	282	282
query97	2905	2968	2897	2897
query98	248	222	221	221
query99	1330	1431	1307	1307
Total cold run time: 272368 ms
Total hot run time: 189497 ms

doris-robot · 2025-09-11T03:38:52Z

ClickBench: Total hot run time: 29.97 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95eb5830363f9ccd9f0fe7d465b1408ee17a1e3e, data reload: false

query1	0.06	0.06	0.05
query2	0.09	0.06	0.06
query3	0.26	0.09	0.09
query4	1.61	0.11	0.12
query5	0.28	0.28	0.25
query6	1.17	0.66	0.66
query7	0.04	0.02	0.03
query8	0.06	0.05	0.05
query9	0.62	0.54	0.51
query10	0.58	0.57	0.58
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.63	0.63	0.61
query14	1.03	1.03	1.04
query15	0.88	0.85	0.85
query16	0.40	0.40	0.40
query17	1.05	1.04	1.06
query18	0.22	0.20	0.21
query19	1.99	1.82	1.82
query20	0.01	0.02	0.01
query21	15.40	0.98	0.58
query22	0.78	1.13	0.78
query23	14.83	1.41	0.62
query24	6.55	0.85	0.82
query25	0.52	0.20	0.15
query26	0.62	0.18	0.13
query27	0.06	0.05	0.06
query28	9.69	0.99	0.44
query29	12.59	3.90	3.23
query30	0.31	0.14	0.11
query31	2.83	0.62	0.38
query32	3.25	0.62	0.49
query33	3.03	3.08	3.11
query34	16.05	5.56	4.81
query35	5.00	4.90	4.91
query36	0.70	0.52	0.49
query37	0.10	0.07	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.02
query40	0.19	0.17	0.14
query41	0.08	0.02	0.02
query42	0.03	0.04	0.03
query43	0.05	0.03	0.03
Total cold run time: 104.07 s
Total hot run time: 29.97 s

yujun777 · 2025-09-11T03:40:50Z

run buildall

doris-robot · 2025-09-11T04:13:03Z

TPC-H: Total hot run time: 34800 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c4209d4eb37eccaa4a678b778465c66b105c4888, data reload: false

------ Round 1 ----------------------------------
q1	17602	5194	5076	5076
q2	1976	309	212	212
q3	10280	1317	713	713
q4	10232	1032	524	524
q5	7532	2438	2343	2343
q6	191	183	140	140
q7	967	764	650	650
q8	9363	1345	1133	1133
q9	6935	5169	5197	5169
q10	6971	2397	1984	1984
q11	475	309	288	288
q12	364	370	235	235
q13	17787	3698	3037	3037
q14	252	242	218	218
q15	571	493	493	493
q16	1014	1000	960	960
q17	609	875	364	364
q18	7350	7137	7149	7137
q19	1570	972	561	561
q20	359	336	232	232
q21	3684	2566	2346	2346
q22	1071	1050	985	985
Total cold run time: 107155 ms
Total hot run time: 34800 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5175	5092	5095	5092
q2	254	335	232	232
q3	2178	2699	2309	2309
q4	1316	1768	1335	1335
q5	4235	4582	4580	4580
q6	222	181	132	132
q7	2084	2055	1811	1811
q8	2710	2618	2607	2607
q9	7375	7308	7394	7308
q10	3111	3368	2853	2853
q11	588	547	517	517
q12	712	802	628	628
q13	3539	3904	3333	3333
q14	307	323	292	292
q15	528	479	476	476
q16	1096	1161	1068	1068
q17	1165	1598	1435	1435
q18	7965	7746	7705	7705
q19	804	822	917	822
q20	1873	1979	1871	1871
q21	4799	4435	4353	4353
q22	1098	1023	996	996
Total cold run time: 53134 ms
Total hot run time: 51755 ms

doris-robot · 2025-09-11T04:24:47Z

TPC-DS: Total hot run time: 188981 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c4209d4eb37eccaa4a678b778465c66b105c4888, data reload: false

query1	1040	451	439	439
query2	6549	1683	1730	1683
query3	6753	233	231	231
query4	26123	23363	23089	23089
query5	4443	648	505	505
query6	352	230	218	218
query7	4658	518	305	305
query8	300	244	266	244
query9	8690	2941	2929	2929
query10	498	364	313	313
query11	15721	15343	14785	14785
query12	181	128	121	121
query13	1683	559	450	450
query14	10829	9291	9266	9266
query15	217	200	172	172
query16	7331	685	489	489
query17	1218	742	617	617
query18	1999	446	352	352
query19	211	201	178	178
query20	133	140	125	125
query21	218	134	114	114
query22	4090	4238	4042	4042
query23	33642	33113	32876	32876
query24	8105	2354	2411	2354
query25	602	539	429	429
query26	1226	279	169	169
query27	2724	551	368	368
query28	4470	2261	2230	2230
query29	815	617	498	498
query30	291	231	201	201
query31	926	800	737	737
query32	91	84	94	84
query33	581	400	346	346
query34	791	867	525	525
query35	835	861	744	744
query36	996	1008	939	939
query37	126	118	105	105
query38	3515	3559	3510	3510
query39	1500	1468	1445	1445
query40	227	135	125	125
query41	66	62	64	62
query42	131	115	127	115
query43	527	481	487	481
query44	1332	857	868	857
query45	184	178	181	178
query46	858	1012	662	662
query47	1780	1794	1738	1738
query48	397	412	316	316
query49	772	530	409	409
query50	669	684	404	404
query51	3920	3927	3899	3899
query52	118	117	113	113
query53	254	268	195	195
query54	620	611	571	571
query55	98	93	93	93
query56	349	367	346	346
query57	1260	1190	1138	1138
query58	294	285	283	283
query59	2627	2794	2551	2551
query60	358	362	343	343
query61	166	160	159	159
query62	831	741	676	676
query63	246	204	203	203
query64	4531	1153	845	845
query65	4052	3979	3954	3954
query66	1166	457	353	353
query67	15353	15140	14954	14954
query68	7971	923	587	587
query69	495	326	296	296
query70	1382	1272	1232	1232
query71	564	343	316	316
query72	5994	5118	4990	4990
query73	656	575	358	358
query74	8856	9036	8958	8958
query75	3899	3270	2735	2735
query76	3652	1163	732	732
query77	802	406	354	354
query78	9607	9626	8917	8917
query79	2558	891	669	669
query80	671	571	518	518
query81	498	270	241	241
query82	432	173	154	154
query83	297	255	250	250
query84	307	118	96	96
query85	888	459	422	422
query86	355	317	313	313
query87	3728	3706	3658	3658
query88	3434	2199	2206	2199
query89	403	320	298	298
query90	1921	226	221	221
query91	164	169	139	139
query92	99	78	74	74
query93	1840	975	641	641
query94	698	440	320	320
query95	410	345	378	345
query96	482	576	282	282
query97	2975	3058	2887	2887
query98	252	231	223	223
query99	1422	1424	1306	1306
Total cold run time: 275371 ms
Total hot run time: 188981 ms

doris-robot · 2025-09-11T04:30:14Z

ClickBench: Total hot run time: 29.44 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c4209d4eb37eccaa4a678b778465c66b105c4888, data reload: false

query1	0.06	0.06	0.04
query2	0.09	0.05	0.08
query3	0.27	0.08	0.07
query4	1.61	0.12	0.11
query5	0.28	0.26	0.25
query6	1.16	0.65	0.63
query7	0.03	0.03	0.03
query8	0.05	0.05	0.05
query9	0.65	0.52	0.52
query10	0.58	0.58	0.57
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.64	0.63	0.62
query14	1.03	1.04	1.01
query15	0.86	0.85	0.88
query16	0.41	0.41	0.41
query17	1.01	1.04	1.04
query18	0.22	0.21	0.20
query19	1.91	1.85	1.83
query20	0.02	0.02	0.01
query21	15.41	0.97	0.63
query22	0.78	1.13	0.75
query23	14.96	1.44	0.61
query24	7.01	1.11	0.35
query25	0.47	0.27	0.08
query26	0.51	0.16	0.14
query27	0.06	0.05	0.06
query28	9.77	0.96	0.43
query29	12.58	3.91	3.21
query30	0.28	0.12	0.11
query31	2.84	0.60	0.39
query32	3.24	0.56	0.50
query33	3.08	3.10	3.06
query34	16.06	5.47	4.83
query35	4.92	4.89	4.88
query36	0.70	0.51	0.51
query37	0.10	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.04	0.03
query40	0.18	0.16	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.43 s
Total hot run time: 29.44 s

hello-stephen · 2025-09-11T06:17:13Z

FE Regression Coverage Report

Increment line coverage 80.00% (16/20) 🎉
Increment coverage report
Complete coverage report

yujun777 · 2025-09-11T08:08:50Z

run buildall

doris-robot · 2025-09-12T12:23:51Z

ClickBench: Total hot run time: 29.61 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ec3c785d9aea6fb304afa26cce6c631f7018561, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.27	0.26
query6	1.18	0.65	0.63
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.63	0.53	0.52
query10	0.59	0.57	0.60
query11	0.17	0.11	0.11
query12	0.14	0.12	0.12
query13	0.62	0.62	0.63
query14	1.02	1.04	1.04
query15	0.87	0.83	0.86
query16	0.42	0.40	0.43
query17	1.04	1.06	1.08
query18	0.22	0.20	0.20
query19	1.95	1.86	1.79
query20	0.01	0.02	0.01
query21	15.40	0.94	0.59
query22	0.75	1.25	0.63
query23	14.89	1.42	0.67
query24	7.76	1.60	0.50
query25	0.48	0.18	0.23
query26	0.61	0.16	0.13
query27	0.07	0.06	0.06
query28	9.08	0.88	0.42
query29	12.56	3.92	3.28
query30	0.29	0.14	0.11
query31	2.84	0.62	0.38
query32	3.25	0.56	0.49
query33	3.15	3.03	3.11
query34	16.14	5.45	4.85
query35	4.94	4.88	4.94
query36	0.69	0.51	0.52
query37	0.10	0.07	0.08
query38	0.07	0.05	0.05
query39	0.04	0.02	0.02
query40	0.17	0.15	0.14
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.69 s
Total hot run time: 29.61 s

hello-stephen · 2025-09-12T14:42:19Z

FE Regression Coverage Report

Increment line coverage 88.89% (32/36) 🎉
Increment coverage report
Complete coverage report

github-actions · 2025-09-16T07:34:05Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-09-16T07:34:07Z

PR approved by anyone and no changes requested.

…ss precision or cast null #55884 (#56115) cherry pick from #55884

…ss precision or cast null #55884 (#56110) cherry pick from #55884

…ate cause by loss precision or cast null apache#55884 (apache#4826) ## Proposed changes cherry-pick: apache#55884

fix simplify integer like compare with double

34bd2c2

morrySnow requested a review from starocean999 September 10, 2025 14:22

morrySnow added dev/2.1.x dev/3.0.x dev/3.1.x labels Sep 10, 2025

morrySnow reviewed Sep 10, 2025

View reviewed changes

add test

590f5b4

udpate

95eb583

rename variable

c4209d4

yujun777 changed the title ~~[fix](nereids) fix simplify integer like compare with double~~ [fix](nereids) fix simplify integer like compare with big double loss precision Sep 11, 2025

add test

7fcaa33

update test

0a4fd98

yujun777 changed the title ~~[fix](nereids) fix simplify compare predicate cause loss precision and wrong skip cast null~~ [fix](nereids) fix simplify compare predicate cause by loss precision or cast null Sep 15, 2025

starocean999 approved these changes Sep 16, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2025

github-actions bot added the reviewed label Sep 16, 2025

morrySnow added the dev/4.0.x label Sep 16, 2025

morrySnow approved these changes Sep 16, 2025

View reviewed changes

morrySnow merged commit 67302d8 into apache:master Sep 16, 2025
36 of 38 checks passed

github-actions bot added dev/3.0.x-conflict dev/2.1.x-conflict dev/3.1.x-conflict labels Sep 16, 2025

yiguolei pushed a commit that referenced this pull request Sep 16, 2025

branch-2.1: [fix](nereids) fix simplify compare predicate cause by lo…

4078205

…ss precision or cast null #55884 (#56115) cherry pick from #55884

yiguolei added dev/2.1.12-merged and removed dev/2.1.x dev/2.1.x-conflict labels Sep 16, 2025

morrySnow pushed a commit that referenced this pull request Sep 17, 2025

branch-3.1: [fix](nereids) fix simplify compare predicate cause by lo…

050284e

…ss precision or cast null #55884 (#56110) cherry pick from #55884

morrySnow added dev/3.1.1-merged and removed dev/3.1.x dev/3.1.x-conflict labels Sep 17, 2025

morrySnow mentioned this pull request Sep 22, 2025

Release Note 3.1.1 #56289

Closed

yiguolei removed the dev/4.0.x label Sep 29, 2025

morrySnow removed dev/3.0.x dev/3.0.x-conflict labels Oct 16, 2025

Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025

branch-selectdb-doris-3.0: [fix](nereids) fix simplify compare predic…

422943d

…ate cause by loss precision or cast null apache#55884 (apache#4826) ## Proposed changes cherry-pick: apache#55884

Conversation

yujun777 commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Sep 10, 2025

Uh oh!

yujun777 commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

hello-stephen commented Sep 10, 2025

FE UT Coverage Report

Uh oh!

morrySnow Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

yujun777 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

hello-stephen commented Sep 10, 2025

FE Regression Coverage Report

Uh oh!

yujun777 commented Sep 11, 2025

Uh oh!

yujun777 commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

yujun777 commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 11, 2025

Uh oh!

hello-stephen commented Sep 11, 2025

FE Regression Coverage Report

Uh oh!

yujun777 commented Sep 11, 2025

Uh oh!

doris-robot commented Sep 12, 2025

Uh oh!

hello-stephen commented Sep 12, 2025

FE Regression Coverage Report

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

yujun777 commented Sep 10, 2025 •

edited

Loading