Skip to content

branch-3.1: [fix](nereids) fix simplify compare predicate cause by loss precision or cast null #55884#56110

Merged
morrySnow merged 2 commits intoapache:branch-3.1from
yujun777:pick_55884_to_upstream_branch-3.1
Sep 17, 2025
Merged

branch-3.1: [fix](nereids) fix simplify compare predicate cause by loss precision or cast null #55884#56110
morrySnow merged 2 commits intoapache:branch-3.1from
yujun777:pick_55884_to_upstream_branch-3.1

Conversation

@yujun777
Copy link
Contributor

cherry pick from #55884

@yujun777 yujun777 requested a review from morrySnow as a code owner September 16, 2025 10:26
@yujun777
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 33170 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b296e4d29519fb89ad4048e22b982b853840ad7, data reload: false

------ Round 1 ----------------------------------
q1	17634	5598	5448	5448
q2	2032	399	288	288
q3	12055	1259	792	792
q4	10546	877	460	460
q5	9670	2407	2154	2154
q6	193	167	135	135
q7	900	749	624	624
q8	9336	1445	1219	1219
q9	5309	5047	4982	4982
q10	6812	2297	1843	1843
q11	503	289	270	270
q12	345	364	218	218
q13	17799	3594	3018	3018
q14	226	224	212	212
q15	542	465	481	465
q16	428	435	379	379
q17	606	881	369	369
q18	6921	6581	6512	6512
q19	1214	966	554	554
q20	330	329	202	202
q21	2950	2313	2019	2019
q22	1075	1031	1007	1007
Total cold run time: 107426 ms
Total hot run time: 33170 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5576	5518	5535	5518
q2	238	326	240	240
q3	2288	2690	2367	2367
q4	1346	1818	1353	1353
q5	4450	5091	5002	5002
q6	166	156	128	128
q7	2071	1968	1869	1869
q8	2659	2855	2720	2720
q9	7301	7325	7252	7252
q10	3069	3221	2764	2764
q11	593	524	505	505
q12	671	768	627	627
q13	3420	3770	3185	3185
q14	282	310	268	268
q15	530	471	473	471
q16	443	505	436	436
q17	1262	1761	1297	1297
q18	7635	7480	7345	7345
q19	820	943	1210	943
q20	2073	2056	1888	1888
q21	5366	4916	4737	4737
q22	1082	1061	995	995
Total cold run time: 53341 ms
Total hot run time: 51910 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192324 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b296e4d29519fb89ad4048e22b982b853840ad7, data reload: false

query1	943	395	405	395
query2	6256	1956	1911	1911
query3	8691	200	199	199
query4	33086	24317	23560	23560
query5	4327	639	473	473
query6	297	196	173	173
query7	4215	501	327	327
query8	311	244	239	239
query9	9215	2608	2612	2608
query10	498	323	278	278
query11	17925	15476	15268	15268
query12	162	107	106	106
query13	1553	539	419	419
query14	9624	6773	7300	6773
query15	240	196	183	183
query16	8119	652	529	529
query17	1603	785	623	623
query18	2170	428	332	332
query19	227	193	171	171
query20	127	129	120	120
query21	211	127	107	107
query22	4609	4653	4392	4392
query23	35111	34405	33980	33980
query24	7537	2739	2707	2707
query25	572	500	455	455
query26	1166	287	180	180
query27	2243	475	368	368
query28	5183	2215	2235	2215
query29	820	620	467	467
query30	241	191	166	166
query31	1041	938	848	848
query32	110	61	60	60
query33	494	365	309	309
query34	750	870	546	546
query35	799	805	740	740
query36	1018	1072	939	939
query37	106	92	70	70
query38	4096	4053	3987	3987
query39	1525	1465	1462	1462
query40	209	122	108	108
query41	51	50	48	48
query42	127	115	108	108
query43	508	531	488	488
query44	1357	806	827	806
query45	191	177	176	176
query46	880	1049	681	681
query47	1946	2003	1913	1913
query48	418	437	368	368
query49	773	498	429	429
query50	672	704	441	441
query51	7331	7201	7235	7201
query52	103	103	95	95
query53	232	264	193	193
query54	560	561	485	485
query55	85	80	82	80
query56	278	274	263	263
query57	1264	1285	1222	1222
query58	243	219	225	219
query59	3077	3141	2962	2962
query60	303	298	268	268
query61	111	108	109	108
query62	805	720	721	720
query63	231	199	194	194
query64	4557	1011	637	637
query65	3614	3301	3358	3301
query66	1046	406	313	313
query67	16498	15858	15636	15636
query68	7780	833	545	545
query69	493	312	275	275
query70	1187	1079	1115	1079
query71	424	286	266	266
query72	5185	3729	3822	3729
query73	656	743	343	343
query74	10222	9448	8920	8920
query75	3679	3161	2629	2629
query76	3553	1162	772	772
query77	773	373	287	287
query78	10404	10498	9731	9731
query79	2884	860	623	623
query80	730	519	435	435
query81	493	255	224	224
query82	408	118	92	92
query83	166	158	148	148
query84	288	110	79	79
query85	725	358	302	302
query86	345	290	302	290
query87	4288	4488	4294	4294
query88	3291	2418	2401	2401
query89	412	329	303	303
query90	1924	192	191	191
query91	137	139	114	114
query92	64	66	53	53
query93	1454	871	539	539
query94	653	416	292	292
query95	342	281	270	270
query96	490	617	284	284
query97	3244	3289	3155	3155
query98	220	220	203	203
query99	1527	1441	1308	1308
Total cold run time: 293132 ms
Total hot run time: 192324 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b296e4d29519fb89ad4048e22b982b853840ad7, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.06
query4	1.62	0.11	0.11
query5	0.50	0.50	0.54
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.58	0.51	0.49
query10	0.56	0.56	0.56
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	0.77	0.83	0.78
query15	0.83	0.84	0.82
query16	0.39	0.38	0.41
query17	1.03	1.06	1.06
query18	0.25	0.24	0.22
query19	1.92	1.87	1.89
query20	0.02	0.01	0.01
query21	15.38	0.92	0.61
query22	0.74	1.02	0.66
query23	14.92	1.40	0.58
query24	3.27	1.15	1.43
query25	0.17	0.17	0.16
query26	0.22	0.14	0.14
query27	0.05	0.05	0.04
query28	14.20	1.03	0.44
query29	12.65	3.97	3.26
query30	0.25	0.09	0.07
query31	2.82	0.61	0.38
query32	3.23	0.55	0.47
query33	3.02	3.00	3.06
query34	16.58	5.19	4.55
query35	4.64	4.58	4.54
query36	0.62	0.51	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 104.16 s
Total hot run time: 29.35 s

@morrySnow morrySnow merged commit 050284e into apache:branch-3.1 Sep 17, 2025
23 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments