branch-3.1: [bugfix](compaction) Fix the issue where input rowsets are prematurely evicted after compaction, causing query failures #55382#55966
Merged
morrySnow merged 1 commit intobranch-3.1from Sep 19, 2025
Conversation
…y evicted after compaction, causing query failures (#55382) ### What problem does this PR solve? Problem Summary: 1. Problem background `There is a critical bug in Doris's compaction: after input rowsets participate in compaction, their expiration time calculation incorrectly uses the rowset's creation time (creation_time), instead of the compaction completion time` 2. Scene for example: a. After compaction is completed, the rowset should be discarded after another tablet_rowset_stale_sweep_time_sec b. Due to the use of creation time calculation, rowset is immediately eliminated c. The executing query failed, error occurred : [E-230]fail to find path in version_graph. spec_version: 0-1789 versions are already compacted 3. Cause a. In the current implementation, TimestampedVersion is created using rs->creation_time() b. Elimination judgment logic : `rowset_creation_time <= (current_time - tablet_rowset_stale_sweep_time_sec)` c. For earlier created rowsets, even if they have just participated in compaction, they will be immediately discarded due to their long creation time ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
TPC-H: Total hot run time: 32784 ms |
TPC-DS: Total hot run time: 193192 ms |
ClickBench: Total hot run time: 28.43 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morrySnow
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #55382