[Fix](geo) fix memory leak in geo#58004
Merged
zclllyybb merged 6 commits intoapache:masterfrom Nov 25, 2025
Merged
Conversation
linrrzqqq
force-pushed
the
geo-fix
branch
5 times, most recently
from
8869b00 to
057970e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34373 ms |
TPC-DS: Total hot run time: 187388 ms |
ClickBench: Total hot run time: 28.04 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34271 ms |
TPC-DS: Total hot run time: 187777 ms |
ClickBench: Total hot run time: 27.58 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
zclllyybb
reviewed
Nov 14, 2025
be/src/geo/wkt_yacc.y
Outdated
Contributor
There was a problem hiding this comment.
just make them return uptr and move it
zclllyybb
reviewed
Nov 14, 2025
zclllyybb
reviewed
Nov 14, 2025
zclllyybb
reviewed
Nov 14, 2025
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34108 ms |
TPC-DS: Total hot run time: 188810 ms |
ClickBench: Total hot run time: 27.79 s |
HappenLee
reviewed
Nov 20, 2025
yiguolei
previously approved these changes
Nov 21, 2025
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 35004 ms |
TPC-DS: Total hot run time: 185620 ms |
ClickBench: Total hot run time: 27.56 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run vault_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
The current `WkbParse::parse_wkb` function has a memory leak issue
caused by unreleased pointers, the pseudocode is as follows:
```cpp
struct WktContext {
Shape* shape;
Status parse_status;
};
void init (WktContext& ctx) {
ctx.shape = (Shape*) malloc(sizeof(Shape));
ctx.parse_status == GEO_PARSE_OK;
}
void parse_wkt(Shape** to_shape) {
WktContext ctx;
init(ctx);
auto status = wkt_parse();
if (status == GEO_PARSE_OK) {
*to_shape = ctx.shape;
} else {
ctx.parse_status = GEO_PARSE_ERROR;
// Here ctx.shape is not deleted, leading to memory leak
}
}
```
This PR replaces some raw pointers in geo with `unique_ptr` to enhance
memory management safety and reduce potential memory leaks issues.
yiguolei
pushed a commit
that referenced
this pull request
Nov 26, 2025
yiguolei
added
dev/4.0.2-merged
and removed
dev/4.0.x
dev/3.1.x
dev/3.1.x-conflict
labels
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
The current `WkbParse::parse_wkb` function has a memory leak issue
caused by unreleased pointers, the pseudocode is as follows:
```cpp
struct WktContext {
Shape* shape;
Status parse_status;
};
void init (WktContext& ctx) {
ctx.shape = (Shape*) malloc(sizeof(Shape));
ctx.parse_status == GEO_PARSE_OK;
}
void parse_wkt(Shape** to_shape) {
WktContext ctx;
init(ctx);
auto status = wkt_parse();
if (status == GEO_PARSE_OK) {
*to_shape = ctx.shape;
} else {
ctx.parse_status = GEO_PARSE_ERROR;
// Here ctx.shape is not deleted, leading to memory leak
}
}
```
This PR replaces some raw pointers in geo with `unique_ptr` to enhance
memory management safety and reduce potential memory leaks issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The current
WkbParse::parse_wkbfunction has a memory leak issue caused by unreleased pointers, the pseudocode is as follows:This PR replaces some raw pointers in geo with
unique_ptrto enhance memory management safety and reduce potential memory leaks issues.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)