branch-4.0: [Fix](geo) fix memory leak in geo #58004#58365
Merged
yiguolei merged 1 commit intobranch-4.0from Nov 26, 2025
Merged
branch-4.0: [Fix](geo) fix memory leak in geo #58004#58365yiguolei merged 1 commit intobranch-4.0from
yiguolei merged 1 commit intobranch-4.0from
Conversation
The current `WkbParse::parse_wkb` function has a memory leak issue
caused by unreleased pointers, the pseudocode is as follows:
```cpp
struct WktContext {
Shape* shape;
Status parse_status;
};
void init (WktContext& ctx) {
ctx.shape = (Shape*) malloc(sizeof(Shape));
ctx.parse_status == GEO_PARSE_OK;
}
void parse_wkt(Shape** to_shape) {
WktContext ctx;
init(ctx);
auto status = wkt_parse();
if (status == GEO_PARSE_OK) {
*to_shape = ctx.shape;
} else {
ctx.parse_status = GEO_PARSE_ERROR;
// Here ctx.shape is not deleted, leading to memory leak
}
}
```
This PR replaces some raw pointers in geo with `unique_ptr` to enhance
memory management safety and reduce potential memory leaks issues.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #58004