[Fix](agg) fix push agg op in nullable column before projection#58234
Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom Nov 22, 2025
Merged
[Fix](agg) fix push agg op in nullable column before projection#58234BiteTheDDDDt merged 1 commit intoapache:masterfrom
BiteTheDDDDt merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
924060929
previously approved these changes
Nov 21, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34251 ms |
TPC-DS: Total hot run time: 187244 ms |
ClickBench: Total hot run time: 27.23 s |
Contributor
Author
|
run buildall |
28ee2a5 to
08d0c92
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34093 ms |
924060929
approved these changes
Nov 21, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-DS: Total hot run time: 186869 ms |
ClickBench: Total hot run time: 27.31 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
BiteTheDDDDt
approved these changes
Nov 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
[Fix](chrome-extension://dbjibobgilijgolhjdcbdebjhejelffo/agg) Fix push aggregate operation in nullable column before projection # Changes Core Logic Adjustment (AggregateStrategies.java): Removed redundant Count function-specific nullable slot checking logic, unifying aggregate function argument validation into a single stream-based check Enhanced argument type verification: For SlotReference and numeric-type Cast (with SlotReference as child) arguments, uniformly collect slots to checkNullSlots for nullability validation Fixed inconsistent aggregate pushdown judgment for nested projection scenarios, ensuring consistent validation logic for aggregate function arguments across different code branches
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…he#58234) [Fix](chrome-extension://dbjibobgilijgolhjdcbdebjhejelffo/agg) Fix push aggregate operation in nullable column before projection # Changes Core Logic Adjustment (AggregateStrategies.java): Removed redundant Count function-specific nullable slot checking logic, unifying aggregate function argument validation into a single stream-based check Enhanced argument type verification: For SlotReference and numeric-type Cast (with SlotReference as child) arguments, uniformly collect slots to checkNullSlots for nullability validation Fixed inconsistent aggregate pushdown judgment for nested projection scenarios, ensuring consistent validation logic for aggregate function arguments across different code branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix Fix push aggregate operation in nullable column before projection
Changes
Core Logic Adjustment (AggregateStrategies.java):
Removed redundant Count function-specific nullable slot checking logic, unifying aggregate function argument validation into a single stream-based check
Enhanced argument type verification: For SlotReference and numeric-type Cast (with SlotReference as child) arguments, uniformly collect slots to checkNullSlots for nullability validation
Fixed inconsistent aggregate pushdown judgment for nested projection scenarios, ensuring consistent validation logic for aggregate function arguments across different code branches
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)