branch-4.0: [Fix](agg) fix push agg op in nullable column before projection #58234#58281
Merged
yiguolei merged 1 commit intobranch-4.0from Nov 25, 2025
Merged
branch-4.0: [Fix](agg) fix push agg op in nullable column before projection #58234#58281yiguolei merged 1 commit intobranch-4.0from
yiguolei merged 1 commit intobranch-4.0from
Conversation
[Fix](chrome-extension://dbjibobgilijgolhjdcbdebjhejelffo/agg) Fix push aggregate operation in nullable column before projection # Changes Core Logic Adjustment (AggregateStrategies.java): Removed redundant Count function-specific nullable slot checking logic, unifying aggregate function argument validation into a single stream-based check Enhanced argument type verification: For SlotReference and numeric-type Cast (with SlotReference as child) arguments, uniformly collect slots to checkNullSlots for nullability validation Fixed inconsistent aggregate pushdown judgment for nested projection scenarios, ensuring consistent validation logic for aggregate function arguments across different code branches
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Nov 25, 2025
github-actions
bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #58234