Skip to content

[fix](time) fix time_to_sec error caused by gabage value of null value#58410

Merged
yiguolei merged 2 commits intoapache:masterfrom
jacktengg:fix-251126
Nov 27, 2025
Merged

[fix](time) fix time_to_sec error caused by gabage value of null value#58410
yiguolei merged 2 commits intoapache:masterfrom
jacktengg:fix-251126

Conversation

@jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@jacktengg jacktengg requested a review from zclllyybb as a code owner November 26, 2025 09:26
@Thearas
Copy link
Contributor

Thearas commented Nov 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34357 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d8dcf179d6b6c49a697350616811ff53f8ca182, data reload: false

------ Round 1 ----------------------------------
q1	13735	5038	4929	4929
q2	1821	351	214	214
q3	4840	1315	776	776
q4	871	865	429	429
q5	2201	2117	2311	2117
q6	206	178	136	136
q7	901	826	638	638
q8	1144	1171	1161	1161
q9	5403	5312	5289	5289
q10	2216	2252	1826	1826
q11	446	302	273	273
q12	295	357	228	228
q13	3351	3702	3095	3095
q14	237	230	216	216
q15	567	529	500	500
q16	1002	1019	943	943
q17	579	876	363	363
q18	7608	7133	7258	7133
q19	556	943	549	549
q20	358	344	238	238
q21	4141	3247	2348	2348
q22	994	1017	956	956
Total cold run time: 53472 ms
Total hot run time: 34357 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4972	4959	4935	4935
q2	335	401	330	330
q3	2234	2739	2338	2338
q4	1362	1843	1368	1368
q5	4282	4203	4176	4176
q6	211	169	127	127
q7	1952	1837	1702	1702
q8	2519	2580	2483	2483
q9	6941	6972	6980	6972
q10	2930	3160	2699	2699
q11	593	505	487	487
q12	631	745	600	600
q13	3264	3662	3116	3116
q14	279	286	277	277
q15	553	512	499	499
q16	1052	1083	1030	1030
q17	1112	1690	1302	1302
q18	7184	7279	7159	7159
q19	776	820	876	820
q20	1967	2032	1847	1847
q21	4864	4311	4446	4311
q22	1100	1098	1013	1013
Total cold run time: 51113 ms
Total hot run time: 49591 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184190 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d8dcf179d6b6c49a697350616811ff53f8ca182, data reload: false

query1	1048	406	429	406
query2	6604	1587	1601	1587
query3	6755	216	222	216
query4	26471	23030	22728	22728
query5	5487	640	474	474
query6	330	229	234	229
query7	4651	498	299	299
query8	294	257	242	242
query9	8725	2584	2566	2566
query10	586	348	311	311
query11	15504	15178	14544	14544
query12	178	115	114	114
query13	1676	583	456	456
query14	11861	8907	8951	8907
query15	212	198	187	187
query16	7674	666	535	535
query17	1621	804	632	632
query18	2046	442	342	342
query19	213	208	182	182
query20	132	124	124	124
query21	216	135	118	118
query22	3863	4087	3917	3917
query23	33045	32201	31953	31953
query24	8140	2384	2389	2384
query25	589	517	444	444
query26	1230	279	163	163
query27	2705	491	348	348
query28	4393	2138	2122	2122
query29	813	605	470	470
query30	347	233	205	205
query31	850	734	626	626
query32	83	71	70	70
query33	601	387	327	327
query34	783	859	529	529
query35	802	827	743	743
query36	908	960	871	871
query37	125	109	86	86
query38	3357	3351	3233	3233
query39	1494	1422	1374	1374
query40	221	129	117	117
query41	66	61	62	61
query42	125	114	109	109
query43	445	457	418	418
query44	1245	757	753	753
query45	194	188	185	185
query46	880	998	635	635
query47	1696	1726	1653	1653
query48	387	429	339	339
query49	776	502	408	408
query50	664	679	402	402
query51	3914	4022	3953	3953
query52	115	113	105	105
query53	245	270	198	198
query54	296	294	279	279
query55	98	95	90	90
query56	336	332	302	302
query57	1157	1154	1116	1116
query58	299	278	274	274
query59	2397	2465	2445	2445
query60	351	346	340	340
query61	161	157	153	153
query62	781	713	659	659
query63	230	195	189	189
query64	4498	1204	930	930
query65	4059	3955	3988	3955
query66	1051	448	331	331
query67	15370	14893	14881	14881
query68	5663	921	649	649
query69	509	332	305	305
query70	1295	1281	1111	1111
query71	456	334	324	324
query72	5929	4921	4958	4921
query73	620	568	343	343
query74	8549	8712	8661	8661
query75	3352	3344	2765	2765
query76	3281	1131	711	711
query77	510	414	309	309
query78	9527	9839	8926	8926
query79	988	796	568	568
query80	1265	597	497	497
query81	561	270	239	239
query82	323	156	131	131
query83	365	257	245	245
query84	264	112	96	96
query85	909	481	440	440
query86	412	287	284	284
query87	3482	3498	3385	3385
query88	2794	2223	2221	2221
query89	399	314	285	285
query90	1693	221	211	211
query91	173	168	144	144
query92	70	67	64	64
query93	1042	973	672	672
query94	757	449	342	342
query95	481	412	392	392
query96	494	557	274	274
query97	2877	3000	2874	2874
query98	229	213	204	204
query99	1294	1402	1253	1253
Total cold run time: 269032 ms
Total hot run time: 184190 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3d8dcf179d6b6c49a697350616811ff53f8ca182, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.26	0.25	0.26
query6	1.18	0.64	0.64
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.52	0.52
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	1.00	1.00	1.01
query15	0.84	0.83	0.83
query16	0.39	0.41	0.40
query17	1.03	1.04	1.04
query18	0.21	0.21	0.19
query19	1.88	1.80	1.81
query20	0.02	0.01	0.01
query21	15.47	0.18	0.13
query22	5.07	0.07	0.05
query23	15.68	0.27	0.09
query24	3.75	0.60	0.41
query25	0.08	0.06	0.07
query26	0.15	0.14	0.14
query27	0.07	0.06	0.05
query28	5.00	1.14	0.92
query29	12.58	3.90	3.21
query30	0.27	0.13	0.12
query31	2.82	0.58	0.38
query32	3.24	0.55	0.48
query33	3.05	3.03	3.08
query34	15.94	5.20	4.52
query35	4.60	4.56	4.58
query36	0.69	0.50	0.49
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.04	0.03
query40	0.17	0.14	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 99.98 s
Total hot run time: 27.43 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.85% (18444/34902)
Line Coverage 38.35% (168600/439585)
Region Coverage 33.14% (130843/394815)
Branch Coverage 34.12% (56332/165098)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.61% (24506/34221)
Line Coverage 58.13% (255288/439200)
Region Coverage 53.34% (213143/399629)
Branch Coverage 54.71% (90812/165995)

@yiguolei yiguolei merged commit b3bd0d8 into apache:master Nov 27, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
#58410)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Nov 27, 2025
…of null value #58410 (#58431)

Cherry-picked from #58410

Co-authored-by: TengJianPing <tengjianping@selectdb.com>
@yiguolei yiguolei mentioned this pull request Dec 2, 2025
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
apache#58410)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants