[improve](varbinary) support varbinary type with topn runtime filter#58721
Merged
zhangstar333 merged 8 commits intoapache:masterfrom Dec 15, 2025
Merged
[improve](varbinary) support varbinary type with topn runtime filter#58721zhangstar333 merged 8 commits intoapache:masterfrom
zhangstar333 merged 8 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zhangstar333
force-pushed
the
varbinary_order_by
branch
from
556e964 to
1b2141b
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34631 ms |
TPC-DS: Total hot run time: 180224 ms |
ClickBench: Total hot run time: 27.26 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34323 ms |
TPC-DS: Total hot run time: 180612 ms |
ClickBench: Total hot run time: 27.5 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34394 ms |
Contributor
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34293 ms |
TPC-DS: Total hot run time: 180033 ms |
ClickBench: Total hot run time: 27.36 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
zhangstar333
force-pushed
the
varbinary_order_by
branch
from
f5d350f to
69c327e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34401 ms |
TPC-DS: Total hot run time: 180087 ms |
ClickBench: Total hot run time: 27.13 s |
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 36494 ms |
TPC-DS: Total hot run time: 181229 ms |
ClickBench: Total hot run time: 27.19 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
morningman
approved these changes
Dec 15, 2025
hubgeter
approved these changes
Dec 15, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Dec 30, 2025
…pache#58721) Problem Summary: support varbinary with topn runtime filter eg: order by binary_col limit n and temp forbid varbinary type at: group by key, join key, comparison predicate in FE part.
Merged
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Dec 31, 2025
…me filter (#58721) (#59479) Problem Summary: pick from master (#58721) support varbinary with topn runtime filter eg: order by binary_col limit n and temp forbid varbinary type at: group by key, join key, comparison predicate in FE part. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
16 tasks
morningman
pushed a commit
that referenced
this pull request
Jan 26, 2026
…ax filter (#60197) ### What problem does this PR solve? Problem Summary: 1. Fixed an issue where the Parquet reader's pushdown predicate row group min-max filter was ineffective due to a refactoring of the column predicate #59187. 2. Removed tablet_schema from RuntimePredicate when performing topn runtime filters, making RuntimePredicate not limited to olap scan node. 3. Removed the feature in #59053 where the Parquet reader could obtain runtime filters in real time, for the purpose of unifying the implementation of olap and file scan node logic in the future. 4. Temporarily disable the topn runtime filter for VARBINARY type, as the implementation of this type in column predicate is incomplete, affecting pr #58721.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
…ax filter (#60197) ### What problem does this PR solve? Problem Summary: 1. Fixed an issue where the Parquet reader's pushdown predicate row group min-max filter was ineffective due to a refactoring of the column predicate #59187. 2. Removed tablet_schema from RuntimePredicate when performing topn runtime filters, making RuntimePredicate not limited to olap scan node. 3. Removed the feature in #59053 where the Parquet reader could obtain runtime filters in real time, for the purpose of unifying the implementation of olap and file scan node logic in the future. 4. Temporarily disable the topn runtime filter for VARBINARY type, as the implementation of this type in column predicate is incomplete, affecting pr #58721.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
support varbinary with topn runtime filter eg: order by binary_col limit n
and temp forbid varbinary type at: group by key, join key, comparison predicate in FE part.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)