Skip to content

[fix](common) fix 'string pointer is null' crash on LOG_DIR when star…#60553

Merged
yiguolei merged 3 commits intoapache:branch-4.0from
freemandealer:pick-branch-4.0-d9c5d495a24
Feb 6, 2026
Merged

[fix](common) fix 'string pointer is null' crash on LOG_DIR when star…#60553
yiguolei merged 3 commits intoapache:branch-4.0from
freemandealer:pick-branch-4.0-d9c5d495a24

Conversation

@freemandealer
Copy link
Contributor

…ting benchmark (#60139)

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ting benchmark (apache#60139)

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative
pipe_tracing directory. This prevents fmt from seeing a null string
pointer.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor Author

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildall

@yiguolei
Copy link
Contributor

yiguolei commented Feb 6, 2026

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

PR approved by anyone and no changes requested.

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 50.00% (5/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.06% (19117/36029)
Line Coverage 36.21% (178150/491940)
Region Coverage 32.77% (137934/420871)
Branch Coverage 33.69% (59808/177524)

@yiguolei
Copy link
Contributor

yiguolei commented Feb 6, 2026

skip buildall

@yiguolei yiguolei merged commit 16b9c27 into apache:branch-4.0 Feb 6, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants