[fix](common) fix 'string pointer is null' crash on LOG_DIR when star…#60553
Merged
yiguolei merged 3 commits intoapache:branch-4.0from Feb 6, 2026
Merged
Conversation
…ting benchmark (apache#60139) Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
freemandealer
commented
Feb 5, 2026
Contributor
Author
freemandealer
left a comment
There was a problem hiding this comment.
run buildall
yiguolei
approved these changes
Feb 6, 2026
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ting benchmark (#60139)
Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)