[fix](common) fix 'string pointer is null' crash on LOG_DIR when starting benchmark#60139
Merged
dataroaring merged 1 commit intoapache:masterfrom Jan 23, 2026
Merged
Conversation
…ting benchmark Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31288 ms |
TPC-DS: Total hot run time: 172708 ms |
ClickBench: Total hot run time: 26.8 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
pingchunzhang
approved these changes
Jan 23, 2026
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Jan 23, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
zclllyybb
approved these changes
Jan 23, 2026
freemandealer
added a commit
to freemandealer/doris
that referenced
this pull request
Feb 5, 2026
…ting benchmark (apache#60139) Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer
added a commit
to freemandealer/doris
that referenced
this pull request
Feb 5, 2026
…ting benchmark (apache#60139) Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Feb 6, 2026
#60553) …ting benchmark (#60139) Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)