Skip to content

[fix](common) fix 'string pointer is null' crash on LOG_DIR when starting benchmark#60139

Merged
dataroaring merged 1 commit intoapache:masterfrom
freemandealer:fix-log-dir
Jan 23, 2026
Merged

[fix](common) fix 'string pointer is null' crash on LOG_DIR when starting benchmark#60139
dataroaring merged 1 commit intoapache:masterfrom
freemandealer:fix-log-dir

Conversation

@freemandealer
Copy link
Contributor

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory. This prevents fmt from seeing a null string pointer.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ting benchmark

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative pipe_tracing directory.
This prevents fmt from seeing a null string pointer.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas
Copy link
Contributor

Thearas commented Jan 22, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31288 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ca6f02cce41c5fb04d3ac17cbd54a2b574ddc3a5, data reload: false

------ Round 1 ----------------------------------
q1	17636	4691	4568	4568
q2	2083	340	198	198
q3	10158	1315	767	767
q4	10247	796	309	309
q5	8484	2087	1889	1889
q6	259	174	144	144
q7	889	746	582	582
q8	9288	1349	1146	1146
q9	5080	4662	4619	4619
q10	6840	1650	1278	1278
q11	504	298	275	275
q12	392	380	222	222
q13	17802	3832	3129	3129
q14	237	233	214	214
q15	603	522	525	522
q16	670	635	568	568
q17	656	783	539	539
q18	6820	6394	6899	6394
q19	1616	1066	649	649
q20	400	368	232	232
q21	3084	2413	2015	2015
q22	1134	1094	1029	1029
Total cold run time: 104882 ms
Total hot run time: 31288 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5108	4979	4963	4963
q2	327	404	313	313
q3	2329	2872	2539	2539
q4	1501	1903	1422	1422
q5	4621	4383	4390	4383
q6	218	170	134	134
q7	2082	1923	1808	1808
q8	2503	2429	2425	2425
q9	7203	7112	7267	7112
q10	2492	2701	2193	2193
q11	529	449	433	433
q12	648	707	580	580
q13	3338	3791	3071	3071
q14	266	287	255	255
q15	534	509	523	509
q16	632	658	622	622
q17	1103	1356	1386	1356
q18	7387	7259	7240	7240
q19	817	821	806	806
q20	1902	1986	1805	1805
q21	4484	4201	4136	4136
q22	1040	1054	972	972
Total cold run time: 51064 ms
Total hot run time: 49077 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172708 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ca6f02cce41c5fb04d3ac17cbd54a2b574ddc3a5, data reload: false

query5	4384	633	503	503
query6	326	208	198	198
query7	4205	446	264	264
query8	331	234	230	230
query9	8696	2851	2874	2851
query10	460	300	261	261
query11	15226	14977	14725	14725
query12	181	113	117	113
query13	1256	445	356	356
query14	5621	3000	2764	2764
query14_1	2650	2607	2650	2607
query15	198	202	169	169
query16	987	487	470	470
query17	1111	692	588	588
query18	2431	444	335	335
query19	211	180	149	149
query20	126	123	123	123
query21	220	138	127	127
query22	3817	3986	3989	3986
query23	15871	15686	15310	15310
query23_1	15645	15472	15556	15472
query24	7204	1543	1121	1121
query24_1	1162	1169	1174	1169
query25	549	461	433	433
query26	1256	272	155	155
query27	2756	454	287	287
query28	4548	2180	2161	2161
query29	807	556	462	462
query30	322	237	207	207
query31	790	626	581	581
query32	85	80	79	79
query33	543	377	322	322
query34	916	871	535	535
query35	722	757	682	682
query36	882	926	839	839
query37	147	107	99	99
query38	2691	2791	2687	2687
query39	764	765	736	736
query39_1	724	710	712	710
query40	219	135	119	119
query41	73	69	67	67
query42	98	90	94	90
query43	444	463	400	400
query44	1293	754	749	749
query45	191	191	179	179
query46	830	950	583	583
query47	1434	1491	1410	1410
query48	357	308	242	242
query49	609	419	347	347
query50	667	268	202	202
query51	3772	3794	3687	3687
query52	89	87	79	79
query53	202	215	164	164
query54	275	274	257	257
query55	82	83	75	75
query56	286	299	302	299
query57	1020	965	881	881
query58	265	260	245	245
query59	2164	1993	2074	1993
query60	322	328	308	308
query61	152	145	146	145
query62	396	364	313	313
query63	186	164	156	156
query64	4964	1203	841	841
query65	3834	3757	3751	3751
query66	1452	417	308	308
query67	15546	15662	15508	15508
query68	2384	1064	721	721
query69	404	302	277	277
query70	984	957	896	896
query71	300	281	267	267
query72	5280	3159	3251	3159
query73	601	743	325	325
query74	8759	8763	8558	8558
query75	2278	2306	1862	1862
query76	2287	1043	627	627
query77	380	407	299	299
query78	9700	9741	9155	9155
query79	2991	840	572	572
query80	1713	514	438	438
query81	576	266	241	241
query82	1016	149	117	117
query83	320	264	235	235
query84	257	123	95	95
query85	893	477	412	412
query86	502	291	277	277
query87	2869	2832	2781	2781
query88	3457	2578	2558	2558
query89	302	254	237	237
query90	2002	166	166	166
query91	177	160	135	135
query92	86	73	71	71
query93	1449	997	646	646
query94	662	301	297	297
query95	587	392	314	314
query96	639	510	235	235
query97	2367	2370	2299	2299
query98	227	199	203	199
query99	613	566	543	543
Total cold run time: 248037 ms
Total hot run time: 172708 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ca6f02cce41c5fb04d3ac17cbd54a2b574ddc3a5, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.27	0.25	0.25
query6	1.14	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.50	0.50
query10	0.56	0.55	0.54
query11	0.15	0.10	0.09
query12	0.14	0.11	0.12
query13	0.60	0.58	0.60
query14	0.97	0.94	0.93
query15	0.79	0.76	0.77
query16	0.39	0.40	0.38
query17	1.03	1.01	1.04
query18	0.23	0.22	0.21
query19	1.94	1.90	1.89
query20	0.02	0.01	0.01
query21	15.43	0.25	0.14
query22	4.93	0.05	0.04
query23	15.89	0.28	0.10
query24	1.07	0.23	0.63
query25	0.12	0.06	0.11
query26	0.15	0.13	0.13
query27	0.08	0.08	0.05
query28	4.54	1.07	0.88
query29	12.51	3.95	3.14
query30	0.27	0.13	0.14
query31	2.82	0.64	0.39
query32	3.24	0.55	0.46
query33	2.96	2.99	3.11
query34	15.82	5.09	4.52
query35	4.48	4.46	4.49
query36	0.66	0.52	0.49
query37	0.12	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.02	0.04
query40	0.17	0.14	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.04
Total cold run time: 96.49 s
Total hot run time: 26.8 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (5/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.46% (19117/36441)
Line Coverage 35.83% (177579/495625)
Region Coverage 32.27% (137128/424969)
Branch Coverage 33.23% (59417/178797)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (5/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.54% (25554/35720)
Line Coverage 54.17% (268187/495093)
Region Coverage 51.86% (222727/429482)
Branch Coverage 53.25% (95617/179568)

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 23, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit d9c5d49 into apache:master Jan 23, 2026
32 of 33 checks passed
freemandealer added a commit to freemandealer/doris that referenced this pull request Feb 5, 2026
…ting benchmark (apache#60139)

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative
pipe_tracing directory. This prevents fmt from seeing a null string
pointer.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Feb 5, 2026
…ting benchmark (apache#60139)

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative
pipe_tracing directory. This prevents fmt from seeing a null string
pointer.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
yiguolei pushed a commit that referenced this pull request Feb 6, 2026
#60553)

…ting benchmark (#60139)

Uses LOG_DIR if set, otherwise config::sys_log_dir, else a relative
pipe_tracing directory. This prevents fmt from seeing a null string
pointer.

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants