Skip to content

[fix](function) Fix array_join to handle non-constant columns.#60612

Merged
zclllyybb merged 2 commits intoapache:masterfrom
Mryange:fix-array_join
Feb 12, 2026
Merged

[fix](function) Fix array_join to handle non-constant columns.#60612
zclllyybb merged 2 commits intoapache:masterfrom
Mryange:fix-array_join

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Feb 9, 2026

What problem does this PR solve?

The previous implementation of array_join was incorrect: it didn't consider whether the inputs were constant columns and always took the first element from each column.

before

mysql> select * from db_array_join; 
+------+-----------------+-------+
| id   | sarr            | s     |
+------+-----------------+-------+
|    1 | ["a", "b", "c"] | 0000  |
|    2 | ["c", "d", "e"] | 11111 |
+------+-----------------+-------+

mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c0000d0000e        |
+--------------------+

now

mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c11111d11111e      |
+--------------------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Mryange Mryange requested a review from zclllyybb as a code owner February 9, 2026 07:33
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange Mryange marked this pull request as draft February 9, 2026 07:35
@Mryange Mryange marked this pull request as ready for review February 9, 2026 07:35
@Mryange
Copy link
Contributor Author

Mryange commented Feb 9, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30368 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41efa5e21c61d1343cfb0a527ebbebca60d67bc1, data reload: false

------ Round 1 ----------------------------------
q1	17643	4477	4291	4291
q2	2036	349	235	235
q3	10179	1398	773	773
q4	10192	815	322	322
q5	7514	2235	1991	1991
q6	194	178	145	145
q7	891	747	593	593
q8	9271	1437	1215	1215
q9	4725	4702	4677	4677
q10	6815	1941	1552	1552
q11	566	307	300	300
q12	337	378	229	229
q13	17814	4121	3250	3250
q14	239	236	236	236
q15	877	818	806	806
q16	701	701	630	630
q17	722	930	450	450
q18	6722	5882	5558	5558
q19	1239	1006	610	610
q20	525	499	384	384
q21	2656	1875	1841	1841
q22	370	319	280	280
Total cold run time: 102228 ms
Total hot run time: 30368 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4357	4324	4352	4324
q2	253	338	252	252
q3	2100	2663	2205	2205
q4	1405	1753	1327	1327
q5	4298	4200	4219	4200
q6	221	177	137	137
q7	1857	1813	1663	1663
q8	2716	2555	2460	2460
q9	7742	7555	7507	7507
q10	2827	3185	2678	2678
q11	556	488	466	466
q12	677	770	635	635
q13	3871	4407	3673	3673
q14	338	302	295	295
q15	851	795	792	792
q16	710	711	763	711
q17	1125	1376	1364	1364
q18	8284	8000	8020	8000
q19	985	948	915	915
q20	2152	2185	2012	2012
q21	4880	4639	4310	4310
q22	593	563	529	529
Total cold run time: 52798 ms
Total hot run time: 50455 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41efa5e21c61d1343cfb0a527ebbebca60d67bc1, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.27	0.24	0.26
query6	1.16	0.67	0.67
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.57	0.50	0.50
query10	0.54	0.54	0.55
query11	0.15	0.10	0.10
query12	0.15	0.10	0.10
query13	0.64	0.62	0.62
query14	1.07	1.06	1.05
query15	0.88	0.87	0.88
query16	0.40	0.42	0.39
query17	1.10	1.18	1.09
query18	0.23	0.22	0.21
query19	2.04	1.97	2.08
query20	0.02	0.02	0.01
query21	15.41	0.28	0.15
query22	5.06	0.06	0.05
query23	15.78	0.29	0.11
query24	1.47	0.36	0.33
query25	0.08	0.12	0.08
query26	0.15	0.14	0.13
query27	0.06	0.10	0.05
query28	3.32	1.14	0.97
query29	12.55	3.94	3.11
query30	0.28	0.13	0.12
query31	2.82	0.65	0.40
query32	3.23	0.60	0.49
query33	3.25	3.37	3.27
query34	16.03	5.40	4.70
query35	4.80	4.80	4.81
query36	0.64	0.50	0.49
query37	0.12	0.07	0.07
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.19	0.16	0.16
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 96.87 s
Total hot run time: 28.36 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (19445/36881)
Line Coverage 36.21% (181022/499883)
Region Coverage 32.57% (140442/431141)
Branch Coverage 33.62% (60871/181039)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (31/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.70% (25910/36137)
Line Coverage 54.29% (270716/498645)
Region Coverage 51.65% (224957/435523)
Branch Coverage 53.16% (96607/181743)

@Mryange
Copy link
Contributor Author

Mryange commented Feb 9, 2026

run p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (31/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.70% (25910/36137)
Line Coverage 54.29% (270710/498645)
Region Coverage 51.64% (224898/435523)
Branch Coverage 53.15% (96594/181743)

@Mryange Mryange changed the title [fix](function) fix array_join functon [fix](function) Fix array_join to handle non-constant columns. Feb 10, 2026
@Mryange
Copy link
Contributor Author

Mryange commented Feb 10, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30361 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

------ Round 1 ----------------------------------
q1	17645	4613	4312	4312
q2	2025	393	241	241
q3	10111	1307	741	741
q4	10193	783	311	311
q5	7546	2193	1957	1957
q6	192	179	145	145
q7	881	742	606	606
q8	9269	1364	1159	1159
q9	4710	4618	4625	4618
q10	6763	1987	1551	1551
q11	465	276	255	255
q12	356	380	230	230
q13	17799	4104	3273	3273
q14	241	247	221	221
q15	913	807	811	807
q16	661	674	628	628
q17	719	777	567	567
q18	6767	5915	5678	5678
q19	1253	976	613	613
q20	498	496	403	403
q21	2550	1794	1796	1794
q22	339	287	251	251
Total cold run time: 101896 ms
Total hot run time: 30361 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4366	4360	4375	4360
q2	269	341	260	260
q3	2127	2701	2212	2212
q4	1358	1730	1263	1263
q5	4289	4249	4291	4249
q6	210	179	137	137
q7	1897	1816	1681	1681
q8	2443	2719	2540	2540
q9	7639	7548	7531	7531
q10	2828	3207	2632	2632
q11	512	448	447	447
q12	738	782	652	652
q13	3873	4409	3688	3688
q14	288	303	281	281
q15	851	824	809	809
q16	680	754	657	657
q17	1165	1326	1381	1326
q18	8253	7936	7876	7876
q19	946	900	879	879
q20	2118	2244	2028	2028
q21	4834	4631	4368	4368
q22	555	541	477	477
Total cold run time: 52239 ms
Total hot run time: 50353 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.11	0.10
query5	0.27	0.25	0.24
query6	1.17	0.68	0.67
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.56	0.51	0.50
query10	0.56	0.55	0.55
query11	0.14	0.09	0.10
query12	0.14	0.11	0.10
query13	0.63	0.62	0.63
query14	1.06	1.06	1.06
query15	0.88	0.85	0.88
query16	0.39	0.40	0.39
query17	1.07	1.09	1.11
query18	0.22	0.21	0.21
query19	2.00	2.01	2.01
query20	0.02	0.02	0.01
query21	15.41	0.28	0.14
query22	5.23	0.06	0.05
query23	16.19	0.29	0.11
query24	1.07	0.71	0.77
query25	0.09	0.08	0.07
query26	0.16	0.14	0.14
query27	0.07	0.09	0.06
query28	4.72	1.18	0.97
query29	12.59	3.94	3.21
query30	0.27	0.14	0.11
query31	2.82	0.64	0.41
query32	3.23	0.60	0.49
query33	3.32	3.26	3.29
query34	16.19	5.44	4.74
query35	4.88	4.82	4.83
query36	0.65	0.50	0.49
query37	0.10	0.07	0.06
query38	0.08	0.05	0.04
query39	0.05	0.03	0.03
query40	0.18	0.17	0.16
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.69 s
Total hot run time: 28.88 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (19450/36903)
Line Coverage 36.20% (181103/500337)
Region Coverage 32.57% (140609/431673)
Branch Coverage 33.63% (60954/181264)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.43% (26552/36158)
Line Coverage 56.51% (282038/499098)
Region Coverage 54.15% (236126/436053)
Branch Coverage 55.80% (101540/181968)

@Mryange
Copy link
Contributor Author

Mryange commented Feb 10, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30167 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

------ Round 1 ----------------------------------
q1	17608	4475	4322	4322
q2	2013	351	268	268
q3	10144	1284	725	725
q4	10202	768	304	304
q5	7502	2080	1973	1973
q6	192	180	147	147
q7	881	720	610	610
q8	9272	1361	1104	1104
q9	4644	4624	4648	4624
q10	6790	1962	1556	1556
q11	451	267	251	251
q12	335	372	224	224
q13	17758	4073	3285	3285
q14	244	253	225	225
q15	895	814	790	790
q16	679	672	654	654
q17	717	870	441	441
q18	6503	5828	5696	5696
q19	1236	984	593	593
q20	509	491	397	397
q21	2517	1805	1737	1737
q22	327	285	241	241
Total cold run time: 101419 ms
Total hot run time: 30167 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4382	4384	4356	4356
q2	257	326	259	259
q3	2116	2673	2243	2243
q4	1352	1712	1300	1300
q5	4220	4139	4193	4139
q6	227	179	137	137
q7	1847	1785	1693	1693
q8	2480	2675	2543	2543
q9	7647	7547	7469	7469
q10	2865	3164	2658	2658
q11	530	455	431	431
q12	704	789	614	614
q13	3973	4371	3795	3795
q14	290	310	283	283
q15	870	825	819	819
q16	709	730	663	663
q17	1170	1380	1391	1380
q18	8057	7785	7990	7785
q19	896	910	827	827
q20	2144	2193	2005	2005
q21	4810	4637	4322	4322
q22	535	495	476	476
Total cold run time: 52081 ms
Total hot run time: 50197 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.14
query5	0.28	0.25	0.25
query6	1.16	0.68	0.67
query7	0.03	0.03	0.03
query8	0.05	0.04	0.03
query9	0.54	0.50	0.49
query10	0.54	0.54	0.56
query11	0.14	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.06	1.09	1.06
query15	0.88	0.87	0.86
query16	0.39	0.39	0.40
query17	1.14	1.14	1.16
query18	0.22	0.22	0.21
query19	2.11	2.03	2.04
query20	0.02	0.02	0.01
query21	15.40	0.25	0.15
query22	5.08	0.06	0.05
query23	15.93	0.28	0.11
query24	1.06	0.74	1.59
query25	0.10	0.10	0.08
query26	0.16	0.14	0.15
query27	0.08	0.06	0.06
query28	4.99	1.14	0.96
query29	12.56	3.95	3.23
query30	0.28	0.13	0.11
query31	2.82	0.64	0.40
query32	3.24	0.60	0.50
query33	3.30	3.24	3.30
query34	16.02	5.39	4.70
query35	4.78	4.83	4.73
query36	0.64	0.49	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.20	0.16	0.14
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.36 s
Total hot run time: 28.83 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.74% (19463/36903)
Line Coverage 36.21% (181180/500337)
Region Coverage 32.58% (140634/431673)
Branch Coverage 33.64% (60983/181264)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.47% (26565/36158)
Line Coverage 56.53% (282140/499098)
Region Coverage 54.17% (236200/436053)
Branch Coverage 55.82% (101581/181968)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.47% (26565/36158)
Line Coverage 56.53% (282140/499098)
Region Coverage 54.17% (236200/436053)
Branch Coverage 55.82% (101581/181968)

@Mryange
Copy link
Contributor Author

Mryange commented Feb 10, 2026

run buildall

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.47% (26564/36158)
Line Coverage 56.53% (282139/499098)
Region Coverage 54.15% (236111/436053)
Branch Coverage 55.82% (101580/181968)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.47% (26564/36158)
Line Coverage 56.53% (282139/499098)
Region Coverage 54.15% (236111/436053)
Branch Coverage 55.82% (101580/181968)

@doris-robot
Copy link

TPC-H: Total hot run time: 30665 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

------ Round 1 ----------------------------------
q1	17646	4599	4280	4280
q2	2059	357	237	237
q3	10171	1270	719	719
q4	10196	784	300	300
q5	7539	2181	1875	1875
q6	196	176	143	143
q7	877	715	593	593
q8	9278	1380	1221	1221
q9	4639	4660	4573	4573
q10	6828	1920	1540	1540
q11	450	247	239	239
q12	340	372	214	214
q13	17758	4070	3213	3213
q14	241	244	212	212
q15	880	798	807	798
q16	675	672	610	610
q17	667	786	536	536
q18	6710	5932	6193	5932
q19	1411	1123	708	708
q20	516	502	395	395
q21	2793	2085	2043	2043
q22	368	302	284	284
Total cold run time: 102238 ms
Total hot run time: 30665 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4566	4574	4656	4574
q2	282	362	272	272
q3	2663	2993	2444	2444
q4	1455	1850	1398	1398
q5	4773	4653	4789	4653
q6	242	205	171	171
q7	2008	2063	1771	1771
q8	2562	2438	2463	2438
q9	7477	7716	7672	7672
q10	2764	3048	2554	2554
q11	497	438	423	423
q12	724	729	561	561
q13	3567	3992	3218	3218
q14	276	286	270	270
q15	816	780	764	764
q16	631	688	643	643
q17	1059	1236	1276	1236
q18	7452	7307	7189	7189
q19	823	822	788	788
q20	1960	2017	1848	1848
q21	4716	4255	4104	4104
q22	478	475	412	412
Total cold run time: 51791 ms
Total hot run time: 49403 ms

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.80% (25961/36158)
Line Coverage 54.41% (271570/499098)
Region Coverage 51.72% (225543/436053)
Branch Coverage 53.33% (97047/181968)

@doris-robot
Copy link

TPC-DS: Total hot run time: 190906 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

query5	4304	596	486	486
query6	320	247	195	195
query7	4214	495	274	274
query8	355	247	239	239
query9	8700	2733	2749	2733
query10	513	375	342	342
query11	16591	16304	16249	16249
query12	180	121	121	121
query13	1268	465	363	363
query14	6149	3207	2975	2975
query14_1	2863	2797	2773	2773
query15	204	189	171	171
query16	955	476	436	436
query17	1092	694	598	598
query18	2428	444	349	349
query19	209	209	186	186
query20	138	127	124	124
query21	210	146	127	127
query22	4760	5096	4951	4951
query23	19095	18519	18196	18196
query23_1	18541	18362	18359	18359
query24	7149	1598	1199	1199
query24_1	1213	1221	1213	1213
query25	551	458	409	409
query26	1242	276	165	165
query27	2751	459	299	299
query28	4538	1883	1847	1847
query29	785	555	465	465
query30	314	252	222	222
query31	902	739	656	656
query32	90	81	77	77
query33	515	341	308	308
query34	968	919	577	577
query35	647	672	604	604
query36	1067	1118	1019	1019
query37	148	108	89	89
query38	2907	2961	2850	2850
query39	959	925	909	909
query39_1	897	885	864	864
query40	222	138	122	122
query41	77	66	67	66
query42	104	102	106	102
query43	415	445	416	416
query44	1333	728	765	728
query45	193	196	180	180
query46	874	984	622	622
query47	2127	2114	2078	2078
query48	311	310	228	228
query49	606	418	355	355
query50	666	273	205	205
query51	4045	4032	4042	4032
query52	102	105	95	95
query53	289	321	273	273
query54	299	265	253	253
query55	84	80	77	77
query56	310	305	308	305
query57	1452	1390	1269	1269
query58	268	267	250	250
query59	2087	2183	2104	2104
query60	334	328	316	316
query61	170	147	151	147
query62	607	571	532	532
query63	300	273	268	268
query64	4854	1252	929	929
query65	4521	4429	4437	4429
query66	1453	436	338	338
query67	16392	16387	16277	16277
query68	2363	1062	732	732
query69	415	321	279	279
query70	1034	980	951	951
query71	325	327	300	300
query72	2943	2722	2572	2572
query73	505	552	321	321
query74	9770	9670	9593	9593
query75	2782	2755	2422	2422
query76	2280	1063	655	655
query77	347	361	294	294
query78	11470	11528	10905	10905
query79	1083	838	610	610
query80	727	572	512	512
query81	503	288	256	256
query82	1372	146	116	116
query83	311	256	242	242
query84	248	123	102	102
query85	831	464	432	432
query86	369	342	297	297
query87	3142	3150	3013	3013
query88	3587	2657	2665	2657
query89	397	345	330	330
query90	1920	177	171	171
query91	163	164	130	130
query92	76	74	71	71
query93	883	861	489	489
query94	474	308	292	292
query95	600	335	381	335
query96	657	531	231	231
query97	2492	2487	2402	2402
query98	224	215	206	206
query99	918	930	804	804
Total cold run time: 262218 ms
Total hot run time: 190906 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd406b94aac5082356f38a470d4e96f6b63b93dc, data reload: false

query1	0.05	0.05	0.04
query2	0.10	0.05	0.04
query3	0.25	0.08	0.09
query4	1.61	0.12	0.11
query5	0.25	0.25	0.25
query6	1.17	0.68	0.66
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.57	0.50	0.50
query10	0.55	0.54	0.54
query11	0.15	0.10	0.09
query12	0.14	0.10	0.11
query13	0.63	0.62	0.61
query14	1.06	1.06	1.05
query15	0.87	0.86	0.86
query16	0.39	0.38	0.39
query17	1.16	1.10	1.11
query18	0.23	0.21	0.21
query19	2.04	1.94	2.07
query20	0.02	0.02	0.01
query21	15.39	0.29	0.15
query22	5.11	0.05	0.06
query23	15.98	0.29	0.11
query24	0.95	0.54	0.18
query25	0.09	0.06	0.05
query26	0.15	0.14	0.14
query27	0.08	0.09	0.05
query28	3.77	1.15	0.96
query29	12.56	3.91	3.14
query30	0.27	0.13	0.11
query31	2.81	0.66	0.42
query32	3.24	0.58	0.49
query33	3.24	3.25	3.28
query34	16.22	5.43	4.72
query35	4.77	4.84	4.72
query36	0.65	0.49	0.49
query37	0.10	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.20	0.16	0.16
query41	0.09	0.04	0.04
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 97.19 s
Total hot run time: 28.04 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (19450/36903)
Line Coverage 36.19% (181081/500336)
Region Coverage 32.57% (140597/431669)
Branch Coverage 33.61% (60930/181264)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.76% (25948/36158)
Line Coverage 54.39% (271464/499097)
Region Coverage 51.69% (225412/436049)
Branch Coverage 53.31% (97000/181968)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.76% (25948/36158)
Line Coverage 54.39% (271478/499097)
Region Coverage 51.72% (225519/436049)
Branch Coverage 53.30% (96983/181968)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.76% (25948/36158)
Line Coverage 54.39% (271478/499097)
Region Coverage 51.72% (225519/436049)
Branch Coverage 53.30% (96983/181968)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.41% (26545/36158)
Line Coverage 56.49% (281957/499097)
Region Coverage 54.06% (235731/436049)
Branch Coverage 55.79% (101520/181968)

@Mryange
Copy link
Contributor Author

Mryange commented Feb 11, 2026

run cloud_p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (46/46) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.41% (26545/36158)
Line Coverage 56.49% (281957/499097)
Region Coverage 54.06% (235731/436049)
Branch Coverage 55.79% (101520/181968)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 12, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zclllyybb zclllyybb merged commit 1f5d7c3 into apache:master Feb 12, 2026
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2026
The previous implementation of array_join was incorrect: it didn't
consider whether the inputs were constant columns and always took the
first element from each column.

 before
```sql
mysql> select * from db_array_join; 
+------+-----------------+-------+
| id   | sarr            | s     |
+------+-----------------+-------+
|    1 | ["a", "b", "c"] | 0000  |
|    2 | ["c", "d", "e"] | 11111 |
+------+-----------------+-------+

mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c0000d0000e        |
+--------------------+
```
now
```sql
mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c11111d11111e      |
+--------------------+
```
Mryange added a commit to Mryange/doris that referenced this pull request Feb 12, 2026
…e#60612)

The previous implementation of array_join was incorrect: it didn't
consider whether the inputs were constant columns and always took the
first element from each column.

 before
```sql
mysql> select * from db_array_join; 
+------+-----------------+-------+
| id   | sarr            | s     |
+------+-----------------+-------+
|    1 | ["a", "b", "c"] | 0000  |
|    2 | ["c", "d", "e"] | 11111 |
+------+-----------------+-------+

mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c0000d0000e        |
+--------------------+
```
now
```sql
mysql> select array_join(sarr,s) from db_array_join;
+--------------------+
| array_join(sarr,s) |
+--------------------+
| a0000b0000c        |
| c11111d11111e      |
+--------------------+
```
yiguolei pushed a commit that referenced this pull request Feb 12, 2026
…, Fix array_join to handle non-constant columns. (#60707)

### What problem does this PR solve?

#60612
#60575



### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants