fix(plugin-tables): Add missing skip_dependent_tables#17
Merged
kodiakhq[bot] merged 1 commit intomainfrom Aug 8, 2023
Merged
Conversation
yevgenypats
approved these changes
Aug 8, 2023
This was referenced Aug 8, 2023
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk-python
that referenced
this pull request
Aug 8, 2023
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Aug 8, 2023
#### Summary Goes with cloudquery/plugin-pb#17 <!--
erezrokah
added a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Aug 8, 2023
#### Summary <!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> Goes with cloudquery/plugin-pb#17 and cloudquery/plugin-pb-go#84 --- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not part of the protocol, but part of the SDK:
https://github.com/cloudquery/plugin-sdk/blob/ed96059e82c98435e8f365b847dc28f7cdd5f3b1/plugin/options.go#L23
and should be passed in the CLI here:
https://github.com/cloudquery/cloudquery/blob/aedaf67c3334cd5c825404f0f8850b80dd83dc06/cli/cmd/migrate_v3.go#L80
It's used here:
https://github.com/cloudquery/cloudquery/blob/aedaf67c3334cd5c825404f0f8850b80dd83dc06/plugins/source/aws/resources/plugin/client.go#L65