fix(plugin-tables): Add missing skip_dependent_tables#1136
Merged
erezrokah merged 1 commit intocloudquery:mainfrom Aug 8, 2023
Merged
fix(plugin-tables): Add missing skip_dependent_tables#1136erezrokah merged 1 commit intocloudquery:mainfrom
skip_dependent_tables#1136erezrokah merged 1 commit intocloudquery:mainfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 48.61% 48.60% -0.01%
==========================================
Files 85 85
Lines 7819 7820 +1
==========================================
Hits 3801 3801
- Misses 3684 3685 +1
Partials 334 334
☔ View full report in Codecov by Sentry. |
hermanschaaf
approved these changes
Aug 8, 2023
Member
Author
|
Going to merge this cc @yevgenypats |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.1](v4.3.0...v4.3.1) (2023-08-08) ### Bug Fixes * **plugin-tables:** Add missing `skip_dependent_tables` ([#1136](#1136)) ([65e9f1a](65e9f1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-pb#17 and cloudquery/plugin-pb-go#84
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)