providers/hetzner: fix duplicate attribute prefix#1083
Merged
jlebon merged 1 commit intocoreos:mainfrom Jun 19, 2024
Merged
Conversation
2 tasks
jlebon
approved these changes
Jun 12, 2024
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Thanks! Can you add an entry to the release notes?
apricote
force-pushed
the
hetzner-fix-prefix
branch
from
c5f8e2e to
5e586b4
Compare
Contributor
Author
Done! |
Contributor
Author
|
Not a rust expert, but the CI failures seem unrelated to this PR. error[E0282]: type annotations needed for `Box<_>`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
|
83 | let items = format_items
| ^^^^^
...
86 | Ok(items.into())
| ---- type must be known at this point
|
help: consider giving `items` an explicit type, where the placeholders `_` are specified
|
83 | let items: Box<_> = format_items
| ++++++++
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101. |
Contributor
|
@apricote yeah; its something with the CI. I am taking a look. |
Contributor
Contributor
|
Ok if you do a re-base it should now be good @apricote |
The attributes generated for the hetzner provider had a duplicate
prefix:
AFTERBURN_AFTERBURN_HETZNER_HOSTNAME=flatcar-test
Afterburn already adds the prefix itself in src/providers/mod.rs
`MetadataProvider.write_attributes()`, so the additional prefix added in
the hetzner provider was unnecessary.
Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
auto-merge was automatically disabled
June 19, 2024 16:04
Head branch was pushed to by a user without write access
apricote
force-pushed
the
hetzner-fix-prefix
branch
from
5e586b4 to
6effcd3
Compare
Contributor
Author
|
Rebased 👍 |
jlebon
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attributes generated for the hetzner provider had a duplicate prefix:
Afterburn already adds the prefix itself in src/providers/mod.rs
MetadataProvider.write_attributes(), so the additional prefix added in the hetzner provider was unnecessary.This is a breaking change for the generated output, not sure how you want to handle this. I can also keep the previous output and just add the new correct output next to it.