Update notExists to true when value is empty#2412
Merged
adityamandaleeka merged 2 commits intodotnet:mainfrom Mar 5, 2024
Merged
Update notExists to true when value is empty#2412adityamandaleeka merged 2 commits intodotnet:mainfrom
adityamandaleeka merged 2 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
MihaZupan
approved these changes
Feb 27, 2024
adityamandaleeka
approved these changes
Mar 5, 2024
Member
adityamandaleeka
left a comment
adityamandaleeka
left a comment
There was a problem hiding this comment.
Triage: we're okay with this even though it is technically a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Exists and NotExists are the same when value is empty. Headers with empty values have no semantic meaning in HTTP. So I updated NotExists with empty value to true. This will go against the current behavior by design.
Feel free to post any comments or suggestions. Initial discussion is here #2258 (comment)