A new permalink should be generated and shown after using the re-upload feature

[fqueze]

Patch entirely generated by claude code from the prompt clicking "Re-upload" should generate a new permalink and show it like an initial upload does here's the summary it produced:

✅ Re-upload Permalink Display Implementation

Summary

Successfully implemented the feature to make clicking "Re-upload" generate a new permalink and show it automatically like an initial upload does.

🔧 Changes Made

1. Enhanced MenuButtonsPermalink Component (src/components/app/MenuButtons/Permalink.js)

• Added reference to the ButtonWithPanel component for programmatic control
• Implemented componentDidUpdate to detect when isNewlyPublished changes from false to true
• Automatically opens the permalink panel when a re-upload completes using the existing openPanel() API

2. Added Test Coverage (src/test/components/MenuButtonsPermalinks.test.js)

• Created test case verifying the permalink panel opens automatically after profile publish/re-upload
• Properly handles React state updates with act() wrapper

🚀 How It Works

1. Initial uploads: Continue to work as before using initialOpen={this.props.isNewlyPublished}
2. Re-uploads: When attemptToPublish() completes, it dispatches PROFILE_PUBLISHED setting isNewlyPublished to true
3. Automatic display: The componentDidUpdate method detects this state change and programmatically opens the permalink panel
4. URL generation: Existing URL shortening and display logic handles showing the new permalink

✅ Verification

• Flow type checking: ✅ Passes
• ESLint: ✅ Passes
• Prettier formatting: ✅ Passes
• All existing tests: ✅ Continue to pass (30/30 MenuButtons tests, 2/2 existing permalink tests)
• New test: ✅ Passes (verifies re-upload permalink display behavior)

📝 Technical Details

The implementation leverages the existing architecture:

• Uses the same isNewlyPublished state that handles initial uploads
• Employs the ButtonWithPanel component's public openPanel() method
• Follows existing React lifecycle patterns with componentDidUpdate
• Maintains backward compatibility with all existing functionality

The solution is minimal, non-intrusive, and ensures re-uploads now provide the same user experience as initial uploads by automatically displaying the new permalink.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (a148dac) to head (05e209c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5547   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files         309      309           
  Lines       29879    29883    +4     
  Branches     8037     8038    +1     
=======================================
+ Hits        25736    25740    +4     
  Misses       3552     3552           
  Partials      591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[canova]

Thanks! It works well, but I would prefer to avoid taking another ref. It should be similar to implement this by having a similar logic inside that component since we already pass isNewlyPublished as initialOpen.

[canova]

Looking at this, I think I would like to avoid taking another ref if possible.

Currently it does the job, but the same functionality can be implemented by a prop. Actually we already have this prop as initialOpen. So all we have to do is to make this prop more generic, like open and make sure that it's being handled properly on componentDidUpdate inside that component.

I checked other places and it looks like here is the only place where we use initialOpen, so it should be fine to do that.

It's usually fix things with props if we can instead of refs because that way we let the component handle its state internally. And we make sure that this component doesn't have a different behavior by not breaking the proper encapsulation.

[canova]

Why do we need panelOpen state for this Permalink component? It shouldn't really need to know anything about its children's state. We can simplify this by only passing open={isNewlyPublished} to the child and compute this there.

[canova]

No need to handle closePanel. Just let it open and don't let it close programmatically. User does it already. Maybe a check like this should be enough if (prevOpen !== currentOpen && currentOpen).

[canova]

It looks good, thanks!