Skip to content

Make 'yarn lint --fix' work as an alias to 'yarn lint-fix'.#5563

Merged
mstange merged 2 commits intofirefox-devtools:mainfrom
fqueze:lint-fix
Aug 26, 2025
Merged

Make 'yarn lint --fix' work as an alias to 'yarn lint-fix'.#5563
mstange merged 2 commits intofirefox-devtools:mainfrom
fqueze:lint-fix

Conversation

@fqueze
Copy link
Contributor

@fqueze fqueze commented Aug 22, 2025

Because I'm so used to mach lint --fix, I keep running yarn lint --fix when I need yarn lint-fix. Making yarn lint --fix work seems easier than fixing my muscle memory.

@fqueze fqueze requested a review from canova August 22, 2025 16:04
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.84%. Comparing base (531ad81) to head (9eccc42).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5563   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         309      309           
  Lines       30338    30338           
  Branches     8346     8346           
=======================================
  Hits        26045    26045           
  Misses       3873     3873           
  Partials      420      420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange
Copy link
Contributor

mstange commented Aug 22, 2025

I agree that yarn lint --fix should work.

But I don't think that script is the right place - this is affecting the input, not the output. I think it might be better to have a separate lint.ts script in the scripts directory which replaces the run-p in the current lint command, i.e. which manually fans out to the other lint commands and passes --fix to all if it is run with --fix. Or maybe there's a way to get run-p to do this automatically?

@fqueze
Copy link
Contributor Author

fqueze commented Aug 22, 2025

I agree that yarn lint --fix should work.

But I don't think that script is the right place - this is affecting the input, not the output. I think it might be better to have a separate lint.ts script in the scripts directory which replaces the run-p in the current lint command, i.e. which manually fans out to the other lint commands and passes --fix to all if it is run with --fix. Or maybe there's a way to get run-p to do this automatically?

If it's the "output" word in the "bin/output-fixing-commands.js" name that worries you, we could also just rename that script to "fix-commands.js". I think that script is a place that makes some sense as it's where we already handle something else related to lint "fix". But I'm not opposed to creating a separate script either.

@canova canova requested review from mstange and removed request for canova August 25, 2025 12:03
Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with landing this as is. I looked into fixing it a different way but ended up reworking a whole bunch of stuff so let's just take the simple form to get the immediate benefit.

@mstange
Copy link
Contributor

mstange commented Aug 26, 2025

After thinking about it more I think the word "output" here is actually used as a verb, not as a noun. As in "print the corresponding fixing command to console"

@mstange mstange merged commit 4d20d1c into firefox-devtools:main Aug 26, 2025
15 checks passed
@canova canova mentioned this pull request Sep 2, 2025
canova added a commit that referenced this pull request Sep 2, 2025
Changes:

[Nazım Can Altınova] Display the marker description at the top inside
the marker tooltips (#5534)
[Florian Quèze] Change the 'JavaScript' radio button label to 'Script'
(#5530)
[Markus Stange] Implement profile logic and some selectors for the
function list (#5525)
[Markus Stange] Some small type fixes (#5538)
[Markus Stange] Simplify return type of the callback we pass to
setState. (#5540)
[Markus Stange] Pass the correct value to the reducer's action argument
(#5543)
[Markus Stange] Change withSize to accept PropsWithoutSize as its type
parameter (#5541)
[Nazım Can Altınova] Make sure that the test-debug command runs the
tests properly (#5545)
[Markus Stange] Improve type coverage involving network phases (#5539)
[Markus Stange] Change implementation of withChartViewport (#5542)
[Florian Quèze] A new permalink should be generated and shown after
using the re-upload feature. (#5547)
[Florian Quèze] Show the vertical ruler in the timeline when hovering
the network chart (#5548)
[Markus Stange] Convert the entire codebase to TypeScript (#5549)
[Nazım Can Altınova] Update the yarn.lock file after recent changes
(#5557)
[Markus Stange] Add proper TypeScript coverage for window-navigation.ts
(#5559)
[Markus Stange] Remove leftover $FlowExpectError comments (#5560)
[Markus Stange] Fix Iterator / Iterable confusion (#5561)
[Nazım Can Altınova] Remove the unneeded test-all:ci script (#5566)
[Nazım Can Altınova] Fix a type case inconsistency (#5569)
[Florian Quèze] Make 'yarn lint --fix' work as an alias to 'yarn
lint-fix'. (#5563)
[Ryan Hunt] Don't stringify JSON again in fetchUrlResponse (#5570)
[Nazım Can Altınova] Upgrade ESLint to version 9 (#5567)
[Markus Stange] Simplify Worker setup, and support .json.gz inputs in
symbolicator-cli (#5556)
[Nazım Can Altınova] Add TypeScript coverage to the intersection
observer mock (#5574)
[Markus Stange] Set the preview selection to null when there is no
selection (#5568)
[Markus Stange] Add tests for query-api.ts (#5571)
[Markus Stange] Enable noUnusedParameters and
@typescript-eslint/no-unused-vars and clean up a few more things (#5576)
[Ryan Hunt] Embed iongraph-web and use for iongraph.json source files
(#5577)
[Markus Stange] Remove recursion in filterThreadToSearchString (#5572)


And thanks to our localizers:

be: Mikalai Udodau
de: Michael Köhler
el: Jim Spentzos
en-CA: chutten
en-GB: Paul
es-CL: ravmn
fr: Théo Chevalier
fur: Fabio Tomat
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
sv-SE: Luna Jernberg
tr: Rua
tr: Selim Şumlu
uk: Іhor Hordiichuk
zh-CN: Olvcpr423
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants