Added flatcar systemd-tmpfiles-setup-dev-early.service#85
Merged
ader1990 merged 1 commit intoflatcar:flatcar-masterfrom Feb 13, 2024
Merged
Added flatcar systemd-tmpfiles-setup-dev-early.service#85ader1990 merged 1 commit intoflatcar:flatcar-masterfrom
ader1990 merged 1 commit intoflatcar:flatcar-masterfrom
Conversation
ader1990
force-pushed
the
fix_kmod_static_nodes
branch
from
4baca82 to
22a1bcc
Compare
ader1990
added a commit
to ader1990/scripts
that referenced
this pull request
Feb 9, 2024
Update the bootengine commit to use the fix from: flatcar/bootengine#85 Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to ader1990/scripts
that referenced
this pull request
Feb 9, 2024
Update the bootengine commit to use the fix from: flatcar/bootengine#85 Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
2 tasks
ader1990
force-pushed
the
fix_kmod_static_nodes
branch
from
22a1bcc to
b0a38d5
Compare
ader1990
force-pushed
the
fix_kmod_static_nodes
branch
from
b0a38d5 to
cc3e5a3
Compare
systemd-tmpfiles-setup-dev-early.service is required to be added instead of systemd-tmpfiles-setup-dev.service, as the kmod-static-nodes service needs to run before the systemd-tmpfiles-setup-dev service. Otherwise, the static links like /dev/vhost-net, will not be created. Once systemd >= 253 is used, the systemd-tmpfiles-setup-dev-early.service definition can be removed, as it is already built in. `--gracefuly` flag is not supported for the systemd 252 version, so it had to be removed. See systemd upstream definition: https://github.com/systemd/systemd/blob/main/units/systemd-tmpfiles-setup-dev-early.service Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
force-pushed
the
fix_kmod_static_nodes
branch
from
cc3e5a3 to
5f73716
Compare
Contributor
Author
|
While testing this PR, an issue was seen with oem-cloudinit service failing. Fixed by #86. |
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 13, 2024
Update the bootengine commit id to use the fix from: flatcar/bootengine#85 Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
2 tasks
pothos
approved these changes
Feb 13, 2024
Member
|
You can merge (and then update the scripts PR to use the merge commit ID) |
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 13, 2024
Update the bootengine commit id to use the fix from: flatcar/bootengine#85 Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
ader1990
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 14, 2024
Update the bootengine commit id to use the fix from: flatcar/bootengine#85 Fixes kubevirt vm creation by ensuring that /dev/vhost-net static node gets created Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
pothos
pushed a commit
to flatcar/scripts
that referenced
this pull request
Mar 5, 2024
Update the bootengine commit id to use the fix from: flatcar/bootengine#85 Fixes kubevirt vm creation by ensuring that /dev/vhost-net static node gets created Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd-tmpfiles-setup-dev-early.service is required to be added instead of systemd-tmpfiles-setup-dev.service, as the kmod-static-nodes service needs to run before the systemd-tmpfiles-setup-dev service.
Otherwise, the static links like /dev/vhost-net, will not be created.
Once systemd >= 253 is used, the systemd-tmpfiles-setup-dev-early.service definition can be removed, as it is already built in.
--gracefulyflag is not supported for the systemd 252 version, so it had to be removed.See systemd upstream definition:
https://github.com/systemd/systemd/blob/main/units/systemd-tmpfiles-setup-dev-early.service
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.