ignition: keep network around when umounting#99
Merged
tormath1 merged 1 commit intoflatcar-masterfrom Sep 16, 2024
Merged
Conversation
chewi
approved these changes
Sep 12, 2024
Contributor
chewi
left a comment
chewi
left a comment
There was a problem hiding this comment.
I was worried this might involve something hacky. This is beautiful!
On some providers (like Equinix Metal), there is a network dependency for the umount stage, network must be still around when ExecStop is executed. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/ignition
branch
from
9f4be0c to
52a641e
Compare
Contributor
Author
|
Force pushed to sync with final upstream commit - it's only a comment diff. |
3 tasks
Contributor
Author
|
cherry-picked to: flatcar-3510-backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps network in the umounting Ignition stage as Equinix Metal needs to POST a status update to Equinix Metal timeline at each stage.
This solves: flatcar/Flatcar#1536
Testing done