sys-kernel/bootengine: pull ignition changes#2308
Merged
Conversation
d511a60 to
0daa718
Compare
this pulls Ignition reordering to fix Equinix Metal issues. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
0daa718 to
46d44d3
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
krnowak
approved these changes
Sep 16, 2024
Contributor
Author
|
cherry-picked to:
For Stable, I'm still considering if we should or not create a |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10883888286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pulls Ignition reordering to fix Equinix Metal issues. (flatcar/bootengine#99) (upstream: coreos/ignition#1940)
Ignition will POST a status update to Equinix Metal at each stage (disk, mount, files, etc.). The failure occurs in mount service, because systemd-networkd is shutted down, as all other services because
initrd-cleanup.serviceis started.initrd-cleanup.serviceis started because Ignition has reported success (last stage files is executed with success) so the Ignition complete target is reached.But the mount service has an ExecStop condition:
which will fail on Equinix Metal because as said: we need the network to POST updates to Equinix Metal
Testing done
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Related to: flatcar/Flatcar#1536