Add a Match section for systemd to not ignore#23
Merged
sayanchowdhury merged 1 commit intoflatcar-masterfrom Jul 21, 2020
Merged
Add a Match section for systemd to not ignore#23sayanchowdhury merged 1 commit intoflatcar-masterfrom
sayanchowdhury merged 1 commit intoflatcar-masterfrom
Conversation
pothos
reviewed
Jul 20, 2020
Member
pothos
left a comment
pothos
left a comment
There was a problem hiding this comment.
Looks good. Same as in flatcar/bootengine#16 I would also expect Name=* to be set in systemd/network/yy-pxe.network
systemd ignores .link and .network files if the Match section is empty Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
force-pushed
the
sayan/upgrade-systemd-to-v245
branch
from
093b8ad to
5407e01
Compare
pothos
approved these changes
Jul 20, 2020
dongsupark
approved these changes
Jul 20, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Sep 14, 2020
This pulls in the new sub key for flatcar-install flatcar/init#25 and a networkd unit to exclude Weave interfaces from DHCP flatcar/init#22 and an update to two other networkd units which lacked a match section that is mandatory in future systemd versions flatcar/init#23
jepio
pushed a commit
that referenced
this pull request
Feb 21, 2022
ignition-generator: make the hostname units optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Match section for systemd to not ignore
systemd 245 ignores .link and .network files if the Match section is empty. More details in the NEWS entry.
This should be merged with flatcar-archive/coreos-overlay#448
Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com
How to use
Testing done
Without these options, the SSH to the machine was broken, and no packets were received by the machine. This fixes the issue.