Migrate to Type=notify

[krishjainx]

[containerd] Migrate to Type=notify in containerd.service

Race condition arises when the containerd service unit assumes services are ready as soon as they start running, rather than when they can actually accept socket requests. To rectify this, changing the unit to Type=notify is required, utilizing the existing containerd support for sd_notify call after socket setup.

References:

• https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type=
• docker restarts containers before containerd socket is opened Flatcar#203

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1993/cldsv/

[jepio]

Can you check git log sdk_container/src/third_party/coreos-overlay/app-emulation/containerd and then update the commit message to specify the package name in the first line and have a bit more information in the commit body about what is being done and why. Thanks

[github-actions]

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5280867453

[krishjainx]

@jepio Does this work?

[jepio]

It's better, but if you look at the git log you'll see that most historical commit messages have a summary line starting with:
app-emulation/containerd and we wrap the text in the body at <80 columns.

[krishjainx]

This resolves it @jepio

[krishjainx]

@dongsupark Unsure why Kola tests fail

[dongsupark]

@dongsupark Unsure why Kola tests fail

From a quick look, CI failed with 17 different failures. Those consist of 3 different types:

• coreos.update.badusr

  • It is expected, an already known issue, please ignore it. That has been always a source of flaky tests, so the kola tests are already trying to retry 5 times at max to get that done. That should be enough mostly in case of (our internal) Jenkins CI runs. With the Github Actions CI, however, somehow it is not enough.

• kubeadm.v1.24.14.calico.cgroupv1.base, etc

  • Looks like flaky tests, That seems to sometimes happen in other PRs as well. Have not looked into its detail.

• devcontainer.systemd-nspawn, devcontainer.docker

  • error: pathspec 'c326eab136' did not match any file(s) known to git
  • It is interesting, because that failure seems to happen only when you ran the tests. (Same as Update commonconfig-6.1 to build kernel with TLS module #865) I am wondering if it has something to do with the dev container trying to clone the default flatcar/scripts git repo, and trying to find a wrong commit c326eab, which exists only in your cloned repo.

[krishjainx]

I think that would be it, yes

[pothos]

Looks good, I just wonder why we don't have tests
Edit: Ah, found something, I could go to Details and approve something there.

[pothos]

This needs a rebase. The tests looked good, the failed devcontainer test just has problems because this PR is from another repo.

[krishjainx]

@pothos Unsure why it says that there are 0 commits here: This is my commit c462c41

[jepio]

You still need to rebase c462c41 onto current main, and push to patch-2 branch. The ebuild location has also changed (app-containers/containerd now)

[krishjainx]

Good? 01d8eda

[jepio]

The commit message still says "app-emulation", that should be "app-containers" too

[dongsupark]

Running Jenkins CI http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1993/cldsv/ for cross-checking.

[dongsupark]

Jenkins CI passed.

A changelog file is missing here as well, like the other one.

[krishjainx]

Added

[dongsupark]

Thanks!