chore(fs): add tests to cover recent PRs

[shcheklein]

Tests for the recent PR regressions:

#322
#321

Also seems that #229 is fixed now. This PR also covers a basic test for it. @simone-viozzi please confirm if / when you have time.

Closes #229

[shcheklein]

C: had to cleanup this a bit (root id is not used anymore, also we now cache ids not a single id even for the base

[shcheklein]

@iterative/dvc a gentle reminder to review this please.

[skshetry]

I am still not sure if we really need fs_factory() fixture. Readability and straightforward test is more important than the duplication.

[shcheklein]

hmm, what is the alternative? I can still explore that in the followup ...

[skshetry]

You can initialize the base_remote_dir automatically in another fixture (with module scope and use it in fs. This will only be called once.

@pytest.fixture(scope="module")
def base_dir(base_remote_dir):
    fs = GDriveFileSystem(base_remote_dir, service_auth)
    fs._gdrive_create_dir(...)
    yield remote_dir
    # cleanup

@pytest.fixture
def fs(base_dir):
   ...

Then, you can just do fs = GDriveFileSystem(base_remote_dir, service_auth) wherever you are doing fs_factory(), right? Or, did I miss something here?

[shcheklein]

okay, I see. There are a few other things (e.g. I'm disabling fs caching in the fixture), probably it all can be moved to the base_dir or something, but I'm not sure it make a big difference

it's easier tbh for me to have all this logic in one place - easier to do changes.