Skip to content

Fix tests#5498

Merged
knative-prow-robot merged 3 commits intoknative:mainfrom
benmoss:fix-tests
Jun 15, 2021
Merged

Fix tests#5498
knative-prow-robot merged 3 commits intoknative:mainfrom
benmoss:fix-tests

Conversation

@benmoss
Copy link
Contributor

@benmoss benmoss commented Jun 11, 2021

Trying to fix up #5495, the changes from knative/pkg#2149 seem to be breaking some e2e tests

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 11, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #5498 (dade824) into main (393e411) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5498      +/-   ##
==========================================
+ Coverage   82.71%   82.74%   +0.03%     
==========================================
  Files         197      198       +1     
  Lines        6098     6098              
==========================================
+ Hits         5044     5046       +2     
+ Misses        729      727       -2     
  Partials      325      325              
Impacted Files Coverage Δ
pkg/kncloudevents/retries.go 84.61% <0.00%> (ø)
pkg/kncloudevents/message_sender.go 86.95% <0.00%> (+4.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393e411...dade824. Read the comment docs.

@benmoss
Copy link
Contributor Author

benmoss commented Jun 11, 2021

I'm not sure why the verify step is failing, no file permissions changed. kind e2e appears to just be a known flake 😢

benmoss added 2 commits June 14, 2021 11:45
Not really sure why it was appending "-pod" here but the
channel-req-status-subscriber-svc didn't exist.
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2021
@slinkydeveloper
Copy link
Contributor

The eventing-kafka failure is unrelated

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@knative-prow-robot knative-prow-robot merged commit d4244d5 into knative:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants