[release-1.17] Reduce mt-broker-controller memory usage with namespaced endpoint informer#8421
Merged
knative-prow[bot] merged 2 commits intoknative:release-1.17from Jan 22, 2025
Conversation
…ormer Currently, the mt-broker-controller is using a cluster-wide endpoints informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE". Using the namespaced informer factory ensures that the watcher is only watching endpoints in the `knative-eventing` (also known as `SYSTEM_NAMESPACE`) namespace. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
5 tasks
knative-prow
bot
added
the
size/XS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #8421 +/- ##
================================================
- Coverage 64.10% 64.10% -0.01%
================================================
Files 388 388
Lines 23359 23363 +4
================================================
+ Hits 14975 14976 +1
- Misses 7589 7591 +2
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
merged commit 4542e6b
into
knative:release-1.17
23 of 24 checks passed
creydr
pushed a commit
to creydr/knative-eventing
that referenced
this pull request
Sep 29, 2025
…ed endpoint informer (knative#8421) * Reduce mt-broker-controller memory usage with namespaced endpoint informer Currently, the mt-broker-controller is using a cluster-wide endpoints informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE". Using the namespaced informer factory ensures that the watcher is only watching endpoints in the `knative-eventing` (also known as `SYSTEM_NAMESPACE`) namespace. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Start informer Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Sep 30, 2025
* [release-1.17] Reduce mt-broker-controller memory usage with namespaced endpoint informer (knative#8421) * Reduce mt-broker-controller memory usage with namespaced endpoint informer Currently, the mt-broker-controller is using a cluster-wide endpoints informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE". Using the namespaced informer factory ensures that the watcher is only watching endpoints in the `knative-eventing` (also known as `SYSTEM_NAMESPACE`) namespace. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Start informer Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Scheduler: Resync reserved periodically to keep state consistent (knative#8453) Scheduler: Resync reserved periodically to keep state consistent Add resyncReserved removes deleted vPods from reserved to keep the state consistent when leadership changes (Promote / Demote). `initReserved` is not enough since the vPod lister can be stale. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Scheduler: log expected vreplicas by vpod (knative#8462) Scheduler: log expected vreplicas by vpod Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec (knative#8560) Compare the entire PodTemplateSpec, instead of just its PodSpec Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> * [release-1.17] Fix hardcoded knative-eventing namespace (knative#8577) * dizzy: Remove hard-coded knative-eventing namespace and replace with system.Namespace() and touch test to get that properly injected Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * broom: Remove yet another hard-coded instance of knative-eventing Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> * [release-1.17] Guard reserved access with lock and create vpods in tests (knative#8504) * Guard reserved access with lock in tests * Create vpods in test Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8418