[release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec#8560
Conversation
knative-prow
bot
added
the
size/XS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #8560 +/- ##
================================================
- Coverage 52.12% 52.11% -0.01%
================================================
Files 388 388
Lines 23414 23416 +2
================================================
- Hits 12205 12204 -1
- Misses 10474 10477 +3
Partials 735 735 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Codestyle action probably needs #8563 |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
cherry-pick-8558-to-release-1.17
branch
from
232d7ac to
b82691e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/retest |
|
/override "codecov/project" |
|
@matzew: Overrode contexts on behalf of matzew: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "codecov/project" |
|
@matzew: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
merged commit eb58703
into
knative:release-1.17
…s PodSpec (knative#8560) Compare the entire PodTemplateSpec, instead of just its PodSpec Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
* [release-1.17] Reduce mt-broker-controller memory usage with namespaced endpoint informer (knative#8421) * Reduce mt-broker-controller memory usage with namespaced endpoint informer Currently, the mt-broker-controller is using a cluster-wide endpoints informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE". Using the namespaced informer factory ensures that the watcher is only watching endpoints in the `knative-eventing` (also known as `SYSTEM_NAMESPACE`) namespace. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Start informer Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Scheduler: Resync reserved periodically to keep state consistent (knative#8453) Scheduler: Resync reserved periodically to keep state consistent Add resyncReserved removes deleted vPods from reserved to keep the state consistent when leadership changes (Promote / Demote). `initReserved` is not enough since the vPod lister can be stale. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Scheduler: log expected vreplicas by vpod (knative#8462) Scheduler: log expected vreplicas by vpod Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * [release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec (knative#8560) Compare the entire PodTemplateSpec, instead of just its PodSpec Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> * [release-1.17] Fix hardcoded knative-eventing namespace (knative#8577) * dizzy: Remove hard-coded knative-eventing namespace and replace with system.Namespace() and touch test to get that properly injected Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * broom: Remove yet another hard-coded instance of knative-eventing Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> * [release-1.17] Guard reserved access with lock and create vpods in tests (knative#8504) * Guard reserved access with lock in tests * Create vpods in test Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
3 participants
This is an automated cherry-pick of #8558