Follow link in terminal results in save dialog

[MartinNuc]

• VSCode Version: 1.14.1
• OS Version: macOS Sierra 10.12.5

Steps to Reproduce:

1. settings: "editor.multiCursorModifier": "ctrlCmd"
2. open integrated terminal
3. run echo https://github.com
4. alt+click on the link
5. save file dialog appears with filename download.html

Expected behaviour: it opens link in a browser

Also the shortcut used to be CMD+click and not ALT+click. I couldn't find where to change it back :-(

This is actually caused by editor.multiCursorModifier settings. I was not aware of that when I created issue.

Reproduces without extensions: Yes

[Tyriar]

Hmm, I can't reproduce, what is your default browser and what is the active program that shows up in the top-left of the screen when you have the save dialog focused?

[MartinNuc]

@Tyriar my default browser is Safari. When I focus download dialog the active program remains Code.

I also tried to write link in the editor and ALT+click works well there.

Tried running Code using code --verbose --disable-extensions but I dont see any output in console when clicking on the link in terminal :(

Is there any way to debug what is actually happening?

[Tyriar]

I'm guessing this is because I just defer to Electron to handle clicking an <a> properly which for some reason isn't behaving in your case. The fix would probably be to explicitly handle opening of the URL at https://github.com/Microsoft/vscode/blob/b4d4d0128fe08798d7fd684d96c0819389eb6bf6/src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts#L75 in the same way that the editor does it.

[cleidigh]

@Tyriar
Seems like something different to work on. Shall I pick this up?

[Tyriar]

@cleidigh sounds good 👍

[cleidigh]

@Tyriar
Clicking links in the integrated terminal on Windows 7 works as expected. (Stable Code, latest Insiders)
Have to reproduce on OS X, seems surprising that would be platform dependent...