Handle Alt+Click for terminal links. Fixes #30761#31263
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom Jul 24, 2017
Merged
Handle Alt+Click for terminal links. Fixes #30761#31263Tyriar merged 2 commits intomicrosoft:masterfrom
Tyriar merged 2 commits intomicrosoft:masterfrom
Conversation
Tyriar
requested changes
Jul 23, 2017
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks great! Just a few minor comments 😃
|
|
||
| this._xterm.setHypertextLinkHandler(this._wrapLinkHandler(uri => { | ||
| this._handleHypertextLink(uri); | ||
| return; |
Member
There was a problem hiding this comment.
Let's remove this return, plus the one in registerLocalLinkHandler. Not sure why I put them there 😅
Contributor
Author
There was a problem hiding this comment.
okay
anonymous function with void return, explicit return is redundant/unnecessary
| callback(true); | ||
| } | ||
|
|
||
| private _handleHypertextLink(url: string) { |
| private _handleHypertextLink(url: string) { | ||
| let uri = Uri.parse(url); | ||
| this._openerService.open(uri); | ||
| return; |
Contributor
Author
|
@Tyriar |
Tyriar
approved these changes
Jul 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Tyriar
Fixes #30761