Support a/path and b/path format for terminal links in git output

[Tyriar]

Example:

diff --git a/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts b/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts
index 84ed8b00b6..3edd37683f 100644
--- a/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts
+++ b/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts

[hhu94]

Do you mind if I take on this issue?

I assume the request is to make a/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts and b/src/vs/workbench/api/electron-browser/mainThreadTerminalService.ts Ctrl-clickable such that the links open the correct versions of the files.

[Tyriar]

@hhu94 sounds good.

The link registration is done here and it's based on regexs:

https://github.com/Microsoft/vscode/blob/b4165f6d32a4ec473a489b97e059b262d1da9dfb/src/vs/workbench/parts/terminal/electron-browser/terminalLinkHandler.ts#L77-L79

We basically want the --- a/ and +++ b/ parts to be matched, but ignored as part of the link.

[hhu94]

@Tyriar I'm having a bit of trouble with getting the two git blob IDs 84ed8b00b6 and 3edd37683f, which are necessary to get the correct versions of the files.

I tried to write a multi-line regex for registerLinkMatcher that captures the blob IDs in groups, along with the paths we want to link, but xterm.js currently only runs the regex on a per line basis (by iterating through the buffer), not on the whole content of the terminal. So the regex didn't find any matches.

I also tried to get the blob IDs by parsing the contents of the terminal manually, but xterm.js doesn't seem to offer a public interface to retrieve the contents. I do see _xterm._core.buffer.iterator but I don't want to rely on an internal implementation to do something like this.

How do you suggest I proceed? Should I submit a PR to xterm.js to allow multi-line regex in _linkifyRows?

[Tyriar]

@hhu94 I'm having a bit of trouble with getting the two git blob IDs 84ed8b00b6 and 3edd37683f, which are necessary to get the correct versions of the files.

Oh I wouldn't go that far, just pointing both links to the current version of the file would be good enough start with.

[hhu94]

Ah I see, that's a lot simpler to do. Will open a PR soon.