Skip to content

Add git diff terminal link handler#67828

Merged
Tyriar merged 2 commits intomicrosoft:masterfrom
hhu94:git-diff-links-simple
Feb 4, 2019
Merged

Add git diff terminal link handler#67828
Tyriar merged 2 commits intomicrosoft:masterfrom
hhu94:git-diff-links-simple

Conversation

@hhu94
Copy link
Contributor

@hhu94 hhu94 commented Feb 4, 2019

Fixes #67238

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

// Matches '+++ b/src/file1', capturing 'src/file1' in group 1
this._gitDiffPostImagePattern = /^\+\+\+ b\/(\S*)/;

this._tooltipCallback = (e: MouseEvent) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing duplication 👍

@Tyriar Tyriar added this to the February 2019 milestone Feb 4, 2019
@Tyriar Tyriar closed this Feb 4, 2019
@Tyriar Tyriar reopened this Feb 4, 2019
@Tyriar Tyriar merged commit 67b30c0 into microsoft:master Feb 4, 2019
@hhu94 hhu94 deleted the git-diff-links-simple branch February 4, 2019 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support a/path and b/path format for terminal links in git output

2 participants