Failure message from Variables request to debugger extension is not surfaced

[gjsjohnmurray]

Issue Type: Bug

Similar to #80464.

The code at

vscode/src/vs/workbench/contrib/debug/common/debugModel.ts

Lines 117 to 127 in 615732f

	private async fetchVariables(start: number | undefined, count: number | undefined, filter: 'indexed' | 'named' | undefined): Promise<Variable[]> {
	try {
	const response = await this.session!.variables(this.reference || 0, this.threadId, filter, start, count);
	return response && response.body && response.body.variables
	? distinct(response.body.variables.filter(v => !!v && isString(v.name)), (v: DebugProtocol.Variable) => v.name).map((v: DebugProtocol.Variable) =>
	new Variable(this.session, this.threadId, this, v.variablesReference, v.name, v.evaluateName, v.value, v.namedVariables, v.indexedVariables, v.presentationHint, v.type))
	: [];
	} catch (e) {
	return [new Variable(this.session, this.threadId, this, 0, e.message, e.message, '', 0, 0, { kind: 'virtual' }, undefined, false)];
	}
	}

caters for an exception thrown by a debugging extension. But they never do that. What they do is return response.success: false and a message in response.message

VS Code version: Code - Insiders 1.41.0-insider (a8158ae, 2019-11-26T21:13:19.311Z)
OS version: Windows_NT x64 10.0.17763

[isidorn]

@gjsjohnmurray Good catch!
Would you be willing to provide a PR that fixes this? The PR should check the response.success and if it is false also return the dummy Variable which would hold the error message.

[gjsjohnmurray]

My initial diagnosis was incorrect, and the fix (see PR) turned out to be trivial.