#85645 display Variables fetch failure message#85842
Merged
isidorn merged 5 commits intomicrosoft:masterfrom Dec 11, 2019
Merged
#85645 display Variables fetch failure message#85842isidorn merged 5 commits intomicrosoft:masterfrom
isidorn merged 5 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks for this PR. Even though PR indeed fixes the issue the actual probel is the following: So ideally we would leave for that variable availble = false and we would fix the rendering Let me know what you think and thanks a lot! |
Contributor
Author
|
@isidorn here's what it now gives. Is that what you meant? |
Collaborator
|
Looks good, tahnks a lot for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes #85645.
A modified vscode-mock-debug is available at https://github.com/gjsjohnmurray/vscode-mock-debug/tree/show-85645 in which the Variables request always returns a failure status and a message.
Prior to this PR the message was not displayed in the Variables panel:

After the fix:
