Skip to content

#85645 display Variables fetch failure message#85842

Merged
isidorn merged 5 commits intomicrosoft:masterfrom
gjsjohnmurray:fix-85645
Dec 11, 2019
Merged

#85645 display Variables fetch failure message#85842
isidorn merged 5 commits intomicrosoft:masterfrom
gjsjohnmurray:fix-85645

Conversation

@gjsjohnmurray
Copy link
Contributor

This PR fixes #85645.

A modified vscode-mock-debug is available at https://github.com/gjsjohnmurray/vscode-mock-debug/tree/show-85645 in which the Variables request always returns a failure status and a message.

Prior to this PR the message was not displayed in the Variables panel:
image

After the fix:
image

@isidorn
Copy link
Collaborator

isidorn commented Dec 2, 2019

Thanks for this PR. Even though PR indeed fixes the issue the actual probel is the following:
Variables that have available = false are not properly rendered in the VARIABLES view. I am not sure why is that. The idea behind available = false is that we can render the variable like an error.

So ideally we would leave for that variable availble = false and we would fix the rendering
If that is not possible, than I am fine that we remove the available attribute altogether (might be a cleaner solution and I do not mind that we loose the special rendering)

Let me know what you think and thanks a lot!

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 2, 2019
@isidorn isidorn added this to the On Deck milestone Dec 2, 2019
@gjsjohnmurray
Copy link
Contributor Author

@isidorn here's what it now gives. Is that what you meant?

image

@isidorn isidorn modified the milestones: On Deck, December 2019 Dec 5, 2019
@isidorn
Copy link
Collaborator

isidorn commented Dec 11, 2019

Looks good, tahnks a lot for the PR!

@isidorn isidorn merged commit 0e65159 into microsoft:master Dec 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
@gjsjohnmurray gjsjohnmurray deleted the fix-85645 branch July 6, 2020 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure message from Variables request to debugger extension is not surfaced

2 participants