Run Active File in Terminal menu should insert quotes for CMD

[rlaney83]

Issue Type: Bug

Ran VSC under 64-bit Windows 7 Pro with two hard drives (C: and D:). Loaded single-file program with Python Extension enabled, from folder with a space in its path (d:\Work\Code Stuff\Test). Inserted ${fileDirname} in Integrated: CWD box under Settings, which works fine selecting New Terminal menu item. Got this ouput when selecting Run Active File menu item,

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.

D:\Work\Code Stuff\Test>d:\Work\Code Stuff\Test\wavtrim.py
'd:\Work\Code' is not recognized as an internal or external command,
operable program or batch file.

D:\Work\Code Stuff\Test>

Obviously, the CWD inserted by VSC worked as expected, but the *.py command should have been wrapped in double quotes to accomodate spaces in my path, resulting in,

D:\Work\Code Stuff\Test>"d:\Work\Code Stuff\Test\wavtrim.py"
. . .

I verified this string works as expected when typed at a Command Prompt launched using Windows Explorer, after changing to my Test directory. Note that Run Without Debugging in the Debug menu works as expected -- it has no problems with directory change or program invocation.

VS Code version: Code 1.42.0 (ae08d54, 2020-02-06T10:51:34.058Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.71GB (11.94GB free)
Process Argv	D:\Work\MEI Stuff\Test\wavtrim_main.py
Screen Reader	no
VM	0%

Extensions (1)

Extension	Author (truncated)	Version
python	ms-	2020.1.58038

[JacksonKearl]

This is Python: Run Active File? Please file at the Python extension: https://github.com/Microsoft/vscode-python

[rlaney83]

This Run Active File selection is in the main VSC Terminal menu. I assume it would apply when attempting to run any program in the Windows CMD terminal. There is nothing Python specific about this problem. Microsoft provided the double-quote solution for referencing files with spaces in their path quite some years ago.

[JacksonKearl]

My bad, reopening.

[dormesica]

Hi,

Saw this issue labaled as "good first issue". I was looking to get into the project for a while now and this seems like a good place to start, so I would like to take it on if that's OK 😁

[Tyriar]

@dormesica sure, I haven't yet reproduced the bug personally but the code for this is located here:

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Lines 473 to 533 in 802fdba

	public preparePathForTerminalAsync(originalPath: string, executable: string, title: string, shellType: TerminalShellType): Promise<string> {
	return new Promise<string>(c => {
	if (!executable) {
	c(originalPath);
	return;
	}
	const hasSpace = originalPath.indexOf(' ') !== -1;
	const pathBasename = basename(executable, '.exe');
	const isPowerShell = pathBasename === 'pwsh' ||
	title === 'pwsh' ||
	pathBasename === 'powershell' ||
	title === 'powershell';
	if (isPowerShell && (hasSpace || originalPath.indexOf('\'') !== -1)) {
	c(`& '${originalPath.replace(/'/g, '\'\'')}'`);
	return;
	}
	if (isWindows) {
	// 17063 is the build number where wsl path was introduced.
	// Update Windows uriPath to be executed in WSL.
	if (shellType !== undefined) {
	if (shellType === WindowsShellType.GitBash) {
	c(originalPath.replace(/\\/g, '/'));
	return;
	}
	else if (shellType === WindowsShellType.Wsl) {
	if (this._terminalNativeService && this._terminalNativeService.getWindowsBuildNumber() >= 17063) {
	c(this._terminalNativeService.getWslPath(originalPath));
	} else {
	c(originalPath.replace(/\\/g, '/'));
	}
	return;
	}
	if (hasSpace) {
	c('"' + originalPath + '"');
	} else {
	c(originalPath);
	}
	} else {
	const lowerExecutable = executable.toLowerCase();
	if (this._terminalNativeService && this._terminalNativeService.getWindowsBuildNumber() >= 17063 &&
	(lowerExecutable.indexOf('wsl') !== -1 || (lowerExecutable.indexOf('bash.exe') !== -1 && lowerExecutable.toLowerCase().indexOf('git') === -1))) {
	c(this._terminalNativeService.getWslPath(originalPath));
	return;
	} else if (hasSpace) {
	c('"' + originalPath + '"');
	} else {
	c(originalPath);
	}
	}
	return;
	}
	c(escapeNonWindowsPath(originalPath));
	});
	}

[dormesica]

@Tyriar

I think I've reproduced the bug. I got this in my PowerShell:

I encountered preparePathForTerminalAsync was tring to debug the RunActiveFileInTerminalAction. I'll take a look in there in the coming days.