Fix run active file in terminal not wrapping with quotes#90847
Fix run active file in terminal not wrapping with quotes#90847Tyriar merged 1 commit intomicrosoft:masterfrom
Conversation
Wait for processReady event before runnigs file.
|
I have no idea why these piplines fail. |
|
@dormesica Chances are that the branch you were working on was failing already. It looks like the current master is passing, so if you update your branch to be in sync with master, your test should pass as well. |
Tyriar
left a comment
There was a problem hiding this comment.
Is the reason this was failing because instance.shellLaunchConfig was not accurate until instance.processReady? Is the repro to run this without a terminal opened?
|
@nrayburn-tech Just before submitting the merge request I pull the master brach and rebase my branch onto it. I'll try again. @Tyriar The reason for the bug was indeed that And yes, in order to reproduce the bug close all terminals and click on Run Active File. |
Wait for processReady event before runnigs file.
This PR fixes #90415