Skip to content

Fix run active file in terminal not wrapping with quotes#90847

Merged
Tyriar merged 1 commit intomicrosoft:masterfrom
dormesica:Fix-#90415
Feb 19, 2020
Merged

Fix run active file in terminal not wrapping with quotes#90847
Tyriar merged 1 commit intomicrosoft:masterfrom
dormesica:Fix-#90415

Conversation

@dormesica
Copy link
Contributor

Wait for processReady event before runnigs file.

This PR fixes #90415

Wait for processReady event before runnigs file.
@dormesica dormesica requested a review from Tyriar February 17, 2020 22:00
@dormesica dormesica changed the title Fix #90415. [WIP] Fix #90415. Feb 17, 2020
@dormesica
Copy link
Contributor Author

I have no idea why these piplines fail.
It seems like the Monaco Editor checks fail but I haven't touched it.

@nrayburn-tech
Copy link
Contributor

@dormesica Chances are that the branch you were working on was failing already. It looks like the current master is passing, so if you update your branch to be in sync with master, your test should pass as well.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason this was failing because instance.shellLaunchConfig was not accurate until instance.processReady? Is the repro to run this without a terminal opened?

@dormesica
Copy link
Contributor Author

dormesica commented Feb 18, 2020

@nrayburn-tech Just before submitting the merge request I pull the master brach and rebase my branch onto it. I'll try again.

@Tyriar The reason for the bug was indeed that instance.shellLaunchConfig was not ready. I was looking for a way to dermine when the TermianlInstance is ready and I encountered the processReady property.
It could be that I got the purpose of this property wrong, so I labeled the PR as WIP, in that case my bad 😬.

And yes, in order to reproduce the bug close all terminals and click on Run Active File.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great thanks! I created #90993 for me to follow up on maybe doing some refactoring to avoid this problem happening outside of terminalInstance.

@Tyriar Tyriar changed the title [WIP] Fix #90415. Fix run active file in terminal not wrapping with quotes Feb 19, 2020
@Tyriar Tyriar added this to the February 2020 milestone Feb 19, 2020
@Tyriar Tyriar merged commit d793ae6 into microsoft:master Feb 19, 2020
@dormesica dormesica deleted the Fix-#90415 branch February 19, 2020 19:00
@dormesica dormesica restored the Fix-#90415 branch March 27, 2020 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Active File in Terminal menu should insert quotes for CMD

3 participants