dropdown.background not applied (debug)

[bpasero]

I played around with dropdown.background to set the background color of the dropdown widget. It works fine in the panel area but e.g. not for the debug dropdown.

That makes me wonder if we possibly have code in debug land that overrides this because the debug view is in the side bar. That is probably not a good idea given you can move views around.

[bpasero]

Same for remote explorer, so it is maybe more generic:

//cc @sandy081 @sbatten

[isidorn]

You are correct we use the sidebar_background for the debug here

I thought the issue is that we also have a green play button which is part of this and we did not want to custmoise it becuase the Green play might not look good on the customised background.

As for the remote explorer I have no clue.

[bpasero]

I think the remote one is covered via #95705

[isidorn]

That one was probably a copy paste mistake from debug land :)

[sbatten]

last milestone @misolori and I saw this differentiation and assumed it was intentional that all sidebar dropdowns do not honor the theme color. this meant that if you drag terminal or output to the sidebar (in their own viewlet), they will also skip using the theme color for dropdown

[isidorn]

I am opening this for a PR.
Code pointer

vscode/src/vs/workbench/contrib/debug/browser/debugActionViewItems.ts

Line 53 in 95f26d2

selectBackground: SIDE_BAR_BACKGROUND

The debug select box should listen to style changes and also style the background of the Green Play button.