Skip to content

Use dropdown.background color in debug dropdown#96576

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-debug-dropdown-color
May 4, 2020
Merged

Use dropdown.background color in debug dropdown#96576
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-debug-dropdown-color

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Apr 29, 2020

This PR fixes #95704

image

Not sure if it's still required to fallback to SIDE_BAR_BACKGROUND for the background is there is no color customization for dropdown.background
Now it looks like this when there is no color customization

image

Also removed some css rules (added in #95935) that were not needed.

@isidorn
Copy link
Collaborator

isidorn commented Apr 29, 2020

@jeanp413 thanks a lot for this PR. Though this week we are in endgame, thus we are testing and no new features. So I will review and merge this next week, assigning to May.

@isidorn isidorn added this to the May 2020 milestone Apr 29, 2020
@isidorn
Copy link
Collaborator

isidorn commented May 4, 2020

Works lovely! Thanks a lot for this PR. Merging in ☀️

@isidorn isidorn merged commit 68213a7 into microsoft:master May 4, 2020
@isidorn
Copy link
Collaborator

isidorn commented May 4, 2020

Actually there are issues on Mac which I did not originally see. So just the default dark theme
Notice the black lines
This widget should ideally be continues the the seperation between the play button and the rest should not be distinguishable.
@jeanp413 let me know if you can look into this. Thanks!

Screenshot 2020-05-04 at 16 28 00

@jeanp413 jeanp413 deleted the fix-debug-dropdown-color branch May 4, 2020 15:58
@jeanp413
Copy link
Contributor Author

jeanp413 commented May 4, 2020

Sure I'll look into it.

@isidorn
Copy link
Collaborator

isidorn commented May 4, 2020

Great, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dropdown.background not applied (debug)

2 participants