Use dropdown.background color in debug dropdown#96576
Merged
isidorn merged 1 commit intomicrosoft:masterfrom May 4, 2020
Merged
Use dropdown.background color in debug dropdown#96576isidorn merged 1 commit intomicrosoft:masterfrom
isidorn merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
@jeanp413 thanks a lot for this PR. Though this week we are in endgame, thus we are testing and no new features. So I will review and merge this next week, assigning to May. |
Collaborator
|
Works lovely! Thanks a lot for this PR. Merging in ☀️ |
Collaborator
|
Actually there are issues on Mac which I did not originally see. So just the default dark theme |
Contributor
Author
|
Sure I'll look into it. |
Collaborator
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes #95704
Not sure if it's still required to fallback to
SIDE_BAR_BACKGROUNDfor the background is there is no color customization fordropdown.backgroundNow it looks like this when there is no color customization
Also removed some css rules (added in #95935) that were not needed.