Unable to open image with URI encoded character in name

[jamesots]

Issue Type: Bug

If I try to open an image with a name such as 'test-%41.png' it says 'An error occurred while loading the image'.

In the developer console, the following error is shown:

Error: Unable to read file '/Users/james.ots/test-A.jpg' (EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, open '/Users/james.ots/test-A.jpg')
    at e.doReadAsFileStream (fileService.ts:457)

VS Code version: Code 1.44.2 (ff91584, 2020-04-16T17:07:18.473Z)
OS version: Darwin x64 19.4.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	3, 3, 4
Memory (System)	8.00GB (0.08GB free)
Process Argv	-psn_0_147492
Screen Reader	no
VM	0%

Extensions: none

[ALapinskas]

Looks like the problem is on the webviewProtocols.ts, line 22

We got request.url, which is a string
'vscode-resource://file///Users/arturas/Downloads/test%D0%B0%41.jpg?version=1588318675861'
looks like it is correct.

Next, when we do
URL.parse(request.url)
it becomes an object

authority: "file"
fragment: ""
path: "///Users/arturas/Downloads/testаA.jpg"
query: "version=1588318675861"
scheme: "vscode-resource"
_formatted: null
_fsPath: null
fsPath: "///Users/arturas/Downloads/testаA.jpg"
__proto__: URI

and the paths are not correct here.

Going down into the URL.parse() i found that the string is being processed inside the url.ts by the

const _rEncodedAsHex = /(%[0-9A-Za-z][0-9A-Za-z])+/g;

function percentDecode(str: string): string {
	if (!str.match(_rEncodedAsHex)) {
		return str;
	}
	return str.replace(_rEncodedAsHex, (match) => decodeURIComponentGraceful(match));
}

This piece of code takes the string, and tries to decode any part started from %,
thats why %41 becomes A

[yume-chan]

@YaAlfred I don't think the decoding process is faulty, but the encoding part.

Every browser will interpret test-%40.jpg as test-A.jpg.

So the url should escape % in the first place.

[ALapinskas]

You're right. The percent ("%") character is missed in the uri.ts encodeTable, and in the encodeURIComponentMinimal() 562 line.