Prevent aggressive image name encoding#96935
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom May 11, 2020
Merged
Conversation
Changes getWebiewContents to getWebviewContents in image-preview extension
Collaborator
|
Thanks for taking a look. Can you please also explain how you tested this change. Specifically, I want to make sure images with special characters in their paths (such as spaces) still work after this change |
Contributor
Author
|
This is how I tested it: Filename: Filename: Should I create some kind of testing code for this? |
Collaborator
|
Thanks. Let's see if this causes any issue or other file paths out there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96689
Following the discussion on the issue thread, I created this PR which prevents aggressive encoding of image names in the builtin image-preview extension. I don't know why it was set this way. In comparison, the markdown-language-features extension does not use it.
Anyway, disabling it seems to solve the issue.
Also, I fixed a typo in the same file.