Fix issues with keybindings list header behavior (#41558)#60217
Fix issues with keybindings list header behavior (#41558)#60217sandy081 merged 1 commit intomicrosoft:masterfrom reima:issue/41558
Conversation
|
There is already a PR open for this #59202 |
|
@sandy081 Thank you for taking a look at this. PR #59202 only addresses part of the issue, and does not follow the solution you proposed in #41789 (comment). Would you please reconsider my PR? Thanks. |
|
@reima I see the other PR has the changes I requested. |
|
@sandy081 Do you mean #41789 with "the other PR"? That one has the requested changes, but the author seems to have to intention of getting it updated and merged (they closed it about 5 months ago). PR #59202 on the other hand only fixes the focus problem, but does not move the list header out of the list. So as I see it there is one complete, but outdated and closed PR (#41789), one incomplete PR (#59202), and one complete PR with an author that just wants to see this issue fixed (this one) 😄 I don't care much about which PR gets merged, as long as it fixes #41558. But I've taken the time to make this PR because there was no other complete and up to date one for this issue. So is there anything I can do to move this forward? |
|
@reima You are right. I am opening this PR for the complete fix. |
|
I've rebased to master. Now one of the unit tests fails on Azure Pipelines. The test seems totally unrelated to the changes, and I cannot reproduce the failure locally. Is there a way to re-run the Azure Pipelines build to determine if the test is flaky? |
|
Thanks @reima. Will take a look. |
|
LGTM |
Resolves #41558
Fixes all the issues displayed in #41558 (comment) by moving the list header out from the list as suggested in #41789 (comment). This also makes the list header stay in place when scrolling the list, which makes it easier to make sense of the columns.