Skip to content

Fix issues with keybindings list header behavior (#41558)#60217

Merged
sandy081 merged 1 commit intomicrosoft:masterfrom
reima:issue/41558
Jan 4, 2019
Merged

Fix issues with keybindings list header behavior (#41558)#60217
sandy081 merged 1 commit intomicrosoft:masterfrom
reima:issue/41558

Conversation

@reima
Copy link
Contributor

@reima reima commented Oct 9, 2018

Resolves #41558

Fixes all the issues displayed in #41558 (comment) by moving the list header out from the list as suggested in #41789 (comment). This also makes the list header stay in place when scrolling the list, which makes it easier to make sense of the columns.

@msftclas
Copy link

msftclas commented Oct 9, 2018

CLA assistant check
All CLA requirements met.

@sandy081 sandy081 self-requested a review October 12, 2018 15:32
@sandy081 sandy081 added this to the October 2018 milestone Oct 12, 2018
@sandy081
Copy link
Member

There is already a PR open for this #59202

@sandy081 sandy081 closed this Oct 12, 2018
@sandy081 sandy081 removed this from the October 2018 milestone Oct 12, 2018
@reima
Copy link
Contributor Author

reima commented Oct 12, 2018

@sandy081 Thank you for taking a look at this. PR #59202 only addresses part of the issue, and does not follow the solution you proposed in #41789 (comment). Would you please reconsider my PR? Thanks.

@sandy081
Copy link
Member

@reima I see the other PR has the changes I requested.

@reima
Copy link
Contributor Author

reima commented Oct 16, 2018

@sandy081 Do you mean #41789 with "the other PR"? That one has the requested changes, but the author seems to have to intention of getting it updated and merged (they closed it about 5 months ago). PR #59202 on the other hand only fixes the focus problem, but does not move the list header out of the list.

So as I see it there is one complete, but outdated and closed PR (#41789), one incomplete PR (#59202), and one complete PR with an author that just wants to see this issue fixed (this one) 😄

I don't care much about which PR gets merged, as long as it fixes #41558. But I've taken the time to make this PR because there was no other complete and up to date one for this issue. So is there anything I can do to move this forward?

@sandy081
Copy link
Member

@reima You are right. I am opening this PR for the complete fix.

@sandy081 sandy081 reopened this Oct 19, 2018
@sandy081 sandy081 added the extensions Issues concerning extensions label Oct 19, 2018
@sandy081 sandy081 added this to the October 2018 milestone Oct 19, 2018
@reima
Copy link
Contributor Author

reima commented Oct 20, 2018

I've rebased to master. Now one of the unit tests fails on Azure Pipelines. The test seems totally unrelated to the changes, and I cannot reproduce the failure locally. Is there a way to re-run the Azure Pipelines build to determine if the test is flaky?

@sandy081
Copy link
Member

Thanks @reima. Will take a look.

@sandy081 sandy081 added keybindings-editor Keybinding editor issues and removed extensions Issues concerning extensions labels Jan 4, 2019
@sandy081 sandy081 merged commit 4fd5c09 into microsoft:master Jan 4, 2019
@sandy081
Copy link
Member

sandy081 commented Jan 4, 2019

LGTM

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

keybindings-editor Keybinding editor issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keybindings editor header problems

5 participants