Support negated .gitignore rules.#73890
Merged
jrieken merged 1 commit intomicrosoft:masterfrom May 24, 2019
Merged
Conversation
Fixes issues microsoft#69035 and microsoft#38112.
|
|
Member
|
@jrieken Did you try this when implementing the ignore markers? |
Member
Nope, but @markspanbroek seems to know this better, the doc actually says this |
Member
|
This actually isn't true on my system (using git 2.17) @markspanbroek Is this a recent fix/feature in git?
|
Contributor
Author
|
@jrieken it requires the -v flag, I also added this to line 1159 of repository.ts. |
Member
Thanks - didn't see and know that. The power of open source! @joaomoreno I am 👍 for this |
jrieken
approved these changes
May 24, 2019
Member
|
This will be in next insiders and stable - Thanks for all the help! |
This was referenced May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues #69035 and #38112.
When invoking
git check-ignoreit returns those paths that match against a .gitignore pattern, whether it's a negated pattern or not. This change ensures that negated pattern matches do not mark a file as ignored.