Skip to content

Fix #88231#88769

Merged
lszomoru merged 1 commit intomicrosoft:masterfrom
AlexStrNik:fix-color-picker
May 12, 2020
Merged

Fix #88231#88769
lszomoru merged 1 commit intomicrosoft:masterfrom
AlexStrNik:fix-color-picker

Conversation

@AlexStrNik
Copy link
Contributor

@AlexStrNik AlexStrNik commented Jan 16, 2020 •
edited
Loading

This PR fixes #88231

The simplest solution to change this line:

if (originalText === this.colorPresentations[i].label) {

to this:

if (originalText.toLowerCase() === this.colorPresentations[i].label) {

src\vs\editor\contrib\colorPicker\colorPickerModel.ts:67

Now when I hover over #1F1F1F it will be recognized as #1f1f1f and when I edit color with the picker, a color will be replaced with lowercased hex representation

Code - OSS Dev 2020-01-16 17-25-09

@AlexStrNik AlexStrNik requested review from octref and rebornix January 16, 2020 14:29
@octref octref added this to the January 2020 milestone Jan 16, 2020
@AlexStrNik AlexStrNik removed the request for review from rebornix January 16, 2020 17:18
@jrieken jrieken modified the milestones: January 2020, February 2020 Feb 10, 2020
@Tyriar Tyriar modified the milestones: February 2020, March 2020 Mar 10, 2020
@octref octref modified the milestones: March 2020, April 2020 Apr 1, 2020
@joaomoreno joaomoreno assigned joaomoreno and unassigned octref and joaomoreno May 5, 2020
@joaomoreno joaomoreno removed this from the April 2020 milestone May 5, 2020
@lszomoru lszomoru requested review from lszomoru and removed request for octref May 12, 2020 08:27
lszomoru
lszomoru approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexStrNik, apologies for the delay it took to get this reviewed and merged.

@lszomoru lszomoru merged commit 331b189 into microsoft:master May 12, 2020
@joaomoreno joaomoreno added this to the May 2020 milestone May 12, 2020
@AlexStrNik
Copy link
Contributor Author

AlexStrNik commented May 12, 2020

@AlexStrNik, apologies for the delay it took to get this reviewed and merged.

Can you also look at #88308?

@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lszomoru lszomoru lszomoru approved these changes

Assignees

@joaomoreno joaomoreno

@lszomoru lszomoru

Labels

None yet

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

Hex color values involving capital letters are changed to RGB when using the Color Picker.

6 participants

@AlexStrNik @lszomoru @joaomoreno @jrieken @Tyriar @octref