Conversation
thaJeztah
force-pushed
the
bump_docker_py
branch
from
976380a to
72d0710
Compare
thaJeztah
added
the
containerd-integration
thaJeztah
force-pushed
the
bump_docker_py
branch
from
72d0710 to
0a5d374
Compare
thaJeztah
removed
the
containerd-integration
thaJeztah
force-pushed
the
bump_docker_py
branch
from
0a5d374 to
dbf3789
Compare
|
We should undraft this if we want to deprecate Container related fields in image inspect in v26: docker/cli#4893 |
|
Ah, yeah; I think we had Looking at docker/docker-py@2a5f354, perhaps we need to do another update there to update it to v25, and we could ask them to tag a new version (could be a "patch" or "minor" release; looks like it's mostly bug fixes, but also compatibility with newer API versions(?) so that could mean "minor" version update. |
|
Hmm looks like we have the skips but At least #47430 shows related docker-py failures. |
Ah, right, I guess we could still skip unconditionally. That said; not 100% against updating to "master"; mostly was trying to stay on tagged versions, but it's not critical |
thaJeztah
changed the title
thaJeztah
changed the title
| # TODO(thaJeztah): set a default VERSION in the tests/integration Dockerfile in docker-py or set SETUPTOOLS_SCM_PRETEND_VERSION conditionally | ||
| # shellcheck disable=SC2086 | ||
| exec docker build ${build_opts} -t "${docker_py_image}" -f tests/Dockerfile "https://github.com/docker/docker-py.git#${DOCKER_PY_COMMIT}" | ||
| exec docker build ${build_opts} -t "${docker_py_image}" --build-arg VERSION="${DOCKER_PY_COMMIT}" -f tests/Dockerfile "https://github.com/docker/docker-py.git#${DOCKER_PY_COMMIT}" |
There was a problem hiding this comment.
Oh no, yet another env var whose value then gets used for SETUPTOOLS_SCM_PRETEND_VERSION ? 🙈
There was a problem hiding this comment.
Yup; looks like it was there before, but at the time it had a default value in the Dockerfile (99.0.0?).
That default was removed, so now it must be passed. We should fix that, because I think we should try to make any Dockerfile have sensible defaults, so that they work without passing build-args (only in exceptional cases where a build-arg MUST be set).
full diff: docker/docker-py@7.0.0...7.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Rebased, and updated the TODO's to include a link to docker/docker-py#3267, which should allow removing the |
4 participants
update docker-py to 7.1.0
full diff: docker/docker-py@7.0.0...7.1.0
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)