fix(network): fall back to unlimited bandwidth in case the legacy global limit is still set #8925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-4.0 |
Member
Author
|
/backport to stable-3.17 |
camilasan
requested changes
Oct 22, 2025
nilsding
force-pushed
the
bugfix/8743/migrate-global-bandwidth-setting
branch
from
9d718a0 to
e08d068
Compare
…bal limit is still set `-2` used to mean "Use global limits", which no longer exist since 3.17.0. As any negative value results in the auto bandwidth limiter to engage, this could result in unexpected slower sync speeds after a client upgrade. Let's just keep handling that value and assume that we want to use unlimited bandwidth. Fixes #8743 Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/8743/migrate-global-bandwidth-setting
branch
from
e08d068 to
a313ea6
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8925.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
camilasan
approved these changes
Oct 23, 2025
|
camilasan
added a commit
that referenced
this pull request
Oct 27, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Oct 27, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Oct 27, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Oct 28, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Oct 29, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Oct 30, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 4, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 6, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 16, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 16, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
mgallien
pushed a commit
that referenced
this pull request
Nov 17, 2025
…ent. Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 17, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
camilasan
added a commit
that referenced
this pull request
Nov 18, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
Aiiaiiio
pushed a commit
that referenced
this pull request
Nov 26, 2025
…ent. - Change variable names for more readable ones. - Related to PRs #8706 and #8925. Signed-off-by: Camila Ayres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-2used to mean "Use global limits", which no longer exist since 3.17.0. As any negative value results in the auto bandwidth limiter to engage, this could result in unexpected slower sync speeds after a client upgrade.Let's just keep handling that value and assume that we want to use unlimited bandwidth.
Fixes #8743