Skip to content

Fix #8914 #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
i2h3 merged 1 commit into from
Oct 23, 2025
Merged

Fix #8914 #8943

i2h3 merged 1 commit into from
Oct 23, 2025

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Oct 23, 2025

fix(file-provider): Fix #8914 by omitting the faulty NSFileProviderRequest argument on enumerator request.

@i2h3
fix(file-provider): Fix #8914 by omitting the faulty NSFileProviderRe…
3220e9e 
…quest argument on enumerator request.

Signed-off-by: Iva Horn <[email protected]>
@i2h3 i2h3 added this to the 4.0.1 milestone Oct 23, 2025
@i2h3 i2h3 requested a review from Copilot October 23, 2025 14:52
@i2h3 i2h3 self-assigned this Oct 23, 2025
@i2h3 i2h3 added the bug label Oct 23, 2025
Copilot AI reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #8914 by removing the faulty NSFileProviderRequest argument from the enumerator logging call. The change corrects a logging error in the File Provider Extension where the request parameter was being incorrectly passed to the logger.

Key Changes

  • Reformatted the enumerator(for:request:) method signature to a single line
  • Removed the .request: request argument from the debug log call

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@i2h3 i2h3 enabled auto-merge October 23, 2025 14:56
@i2h3
Copy link
Collaborator Author

i2h3 commented Oct 23, 2025

/backport to stable-4.0

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8943.zip

Digest: sha256:e9a2a15a5d047bb0039513a5b2ba0d1164359b1afc3201a87531cc924307b8aa

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@i2h3 i2h3 merged commit 83c6bc3 into master Oct 23, 2025
20 checks passed
@i2h3 i2h3 deleted the fix/8914-download-folder-now branch October 23, 2025 15:32
@backportbot backportbot bot mentioned this pull request Oct 23, 2025
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2025

Quality Gate Passed Quality Gate passed

Issues
Image 0 New issues
Image 0 Accepted issues

Measures
Image 0 Security Hotspots
Image 0.0% Coverage on New Code
Image 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nilsding nilsding linked an issue Oct 24, 2025 that may be closed by this pull request
[Bug]: You need to authenticate before accessing this item. #8950
Closed
8 tasks
@nilsding nilsding mentioned this pull request Oct 24, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

@i2h3 i2h3

Labels

bug feature: 📁 file provider

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

[Bug]: You need to authenticate before accessing this item. [Bug]: macOS File Provider "Download Now" on Folders Authentication Alert

3 participants

@i2h3 @nilsding